Fix: ssh connector closes failed connections

Author: doodlesbykumbi

internal/plugin/connectors/ssh/proxy_service.go

@@ -130,6 +130,7 @@ func (proxy *proxyService) Start() error {
 			// https://godoc.org/golang.org/x/crypto/ssh#NewServerConn
 			conn, chans, reqs, err := ssh.NewServerConn(nConn, serverConfig)
 			if err != nil {
+				nConn.Close()
 				logger.Debugf("Failed to handshake: %s", err)
 				continue
 			}
@@ -149,6 +150,7 @@ func (proxy *proxyService) Start() error {
 			go func() {
 				if err := proxy.handleConnections(chans); err != nil {
 					logger.Errorf("Failed on handle connection: %s", err)
+					nConn.Close()
 					return
 				}
 

internal/plugin/connectors/ssh/service_connector.go

@@ -98,6 +98,11 @@ func (h *ServiceConnector) Connect(
 	}
 
 	if server, err = ssh.Dial(serverConfig.Network, serverConfig.Address, &serverConfig.ClientConfig); err != nil {
+		for newChannel := range h.channels {
+			if err := newChannel.Reject(ssh.ConnectionFailed, "secretless unable to dial SSH backend"); err != nil {
+				h.logger.Errorf("Failed to send new channel rejection on dial SSH backend : %s", err)
+			}
+		}
 		return fmt.Errorf("failed to dial SSH backend '%s': %s", serverConfig.Address, err)
 	}