This repository was archived by the owner on Jun 25, 2019. It is now read-only.
fix incorrect relative path when dealing with multiple files having different paths #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…closure, this to prevent the default options from being modified and propagated from call to call (i.e. options.from being set to file.path), resulting in the current file's path being ignored.
Owner
|
Nice catch ! |
MoOx
added a commit
that referenced
this pull request
Jun 8, 2015
fix incorrect relative path when dealing with multiple files having different paths
Owner
|
Released as 1.0.1 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running with no options, the first file's path is set on options and then propagated to subsequent files, which causes files with different paths to be processed with the incorrect path.
i.e. say we process 'index.css' and 'foo/bar.css' (in that order).
index.css will be processed relative to its path
foo/bar.css will be processed with index.css's path
the error is evident if foo/bar.css includes an import statements, which will be resolved relative to index.css rather than foo/bar.css
an issue remains if/when a user passes in any options, as the current code's options still take precedence over the current file's path, but that seemed to be the intent of the code, so it was left as is.