Skip to content

Fix terminal snapshot corruption handling #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cschubiner merged 1 commit into from
Feb 3, 2026
Merged

Fix terminal snapshot corruption handling #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/main/services/TerminalSnapshotService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ async function readSnapshotFile(filePath: string): Promise<StoredSnapshot | null
error,
bytes: Buffer.byteLength(raw, 'utf8'),
});
await removeFile(filePath);
return null;
}
}
Expand All @@ -76,6 +77,25 @@ async function removeFile(filePath: string): Promise<void> {
}
}

async function atomicWriteFile(filePath: string, contents: string): Promise<void> {
const dir = path.dirname(filePath);
const base = path.basename(filePath);
const tmpPath = path.join(dir, `.${base}.${process.pid}.${Date.now()}.tmp`);
await fs.promises.writeFile(tmpPath, contents, 'utf8');
try {
await fs.promises.rename(tmpPath, filePath);
} catch (error) {
const code = (error as NodeJS.ErrnoException)?.code;
if (code === 'EEXIST' || code === 'EPERM') {
await fs.promises.rm(filePath, { force: true });
await fs.promises.rename(tmpPath, filePath);
return;
}
await fs.promises.rm(tmpPath, { force: true });
throw error;
}
}

async function listSnapshots(): Promise<
Array<{ id: string; path: string; stats: StoredSnapshot }>
> {
Expand Down Expand Up @@ -121,7 +141,7 @@ class TerminalSnapshotService {
}

await ensureDir();
await fs.promises.writeFile(snapshotPath(id), json, 'utf8');
await atomicWriteFile(snapshotPath(id), json);
await this.pruneIfNeeded(id);
return { ok: true };
} catch (error) {
Expand Down
Loading