Skip to content

Commit 892db65

Browse files
mmsqeHuangYi
andauthored
Problem: recent bug fixes are not included (#1715)
* Problem: rocksdb 9.8.4 is not used (#1712) for more info, facebook/rocksdb@v9.7.4...v9.8.4 * Problem: query blocks before enable feemarket module get nil pointer error (#1714) * Problem: unable to query historical txs whose module is removed (#1713) * Problem: unable to query historical txs from deleted icaauth module * test * poetry * deps * add unit tets * cleanup * rename * revert integration test * revert * add authz * changelog * test authz * cleanup * register in query * only patch encoding for tx service * Revert "only patch encoding for tx service" This reverts commit 4b1c141. --------- Co-authored-by: HuangYi <[email protected]> --------- Co-authored-by: HuangYi <[email protected]>
1 parent 89ecd5b commit 892db65

File tree

10 files changed

+1308
-16
lines changed

10 files changed

+1308
-16
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Changelog
22

3+
## UNRELEASED
4+
5+
### Bug Fixes
6+
7+
* [#1714](https://github.com/crypto-org-chain/cronos/pull/1714) Avoid nil pointer error when query blocks before feemarket module gets enabled.
8+
* [#1713](https://github.com/crypto-org-chain/cronos/pull/1713) Register legacy codec to allow query historical txs whose modules are removed (icaauth, authz).
9+
10+
### Improvements
11+
12+
* [#1712](https://github.com/crypto-org-chain/cronos/pull/1712) Upgrade rocksdb to `v9.8.4`.
13+
314
*Dec 2, 2024*
415

516
## v1.4.0

app/legacy.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package app
2+
3+
import (
4+
"github.com/cosmos/cosmos-sdk/codec"
5+
cdctypes "github.com/cosmos/cosmos-sdk/codec/types"
6+
"github.com/cosmos/cosmos-sdk/x/authz"
7+
icaauthtypes "github.com/crypto-org-chain/cronos/v2/app/legacy/icaauth/types"
8+
)
9+
10+
func RegisterLegacyCodec(cdc *codec.LegacyAmino) {
11+
icaauthtypes.RegisterCodec(cdc)
12+
authz.RegisterLegacyAminoCodec(cdc)
13+
}
14+
15+
func RegisterLegacyInterfaces(registry cdctypes.InterfaceRegistry) {
16+
icaauthtypes.RegisterInterfaces(registry)
17+
authz.RegisterInterfaces(registry)
18+
}

app/legacy/icaauth/types/codec.go

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
package types
2+
3+
import (
4+
"github.com/cosmos/cosmos-sdk/codec"
5+
cdctypes "github.com/cosmos/cosmos-sdk/codec/types"
6+
sdk "github.com/cosmos/cosmos-sdk/types"
7+
"github.com/cosmos/cosmos-sdk/types/msgservice"
8+
)
9+
10+
func RegisterCodec(cdc *codec.LegacyAmino) {
11+
cdc.RegisterConcrete(&MsgRegisterAccount{}, "icaauth/RegisterAccount", nil)
12+
cdc.RegisterConcrete(&MsgSubmitTx{}, "icaauth/SubmitTx", nil)
13+
}
14+
15+
func RegisterInterfaces(registry cdctypes.InterfaceRegistry) {
16+
registry.RegisterImplementations((*sdk.Msg)(nil),
17+
&MsgRegisterAccount{},
18+
)
19+
registry.RegisterImplementations((*sdk.Msg)(nil),
20+
&MsgSubmitTx{},
21+
)
22+
msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)
23+
}

0 commit comments

Comments
 (0)