-
Notifications
You must be signed in to change notification settings - Fork 373
fix(app): RootMultiStore interface and version mismatch(backport:#1179) #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v6 #1180 +/- ##
==============================================
- Coverage 34.25% 34.22% -0.03%
==============================================
Files 101 101
Lines 17423 17507 +84
==============================================
+ Hits 5968 5992 +24
- Misses 10503 10562 +59
- Partials 952 953 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
update memival,store,versondb related prs crypto-org-chain/cronos#1684 crypto-org-chain/cronos#1685 crypto-org-chain/cronos#1688 (Do not include versionDB.SetSkipVersionZero(true) in app.go) crypto-org-chain/cronos#1751 crypto-org-chain/cronos#1759 (note: Do not include cronos storeloader and upgrades) note: I don't use this. crypto-org-chain/cronos#1780 because it update rocksdbs from version 9.2.1 to 9.11.2
2dfae63 to
7692d73
Compare
| github.com/cometbft/cometbft v0.38.17 | ||
| github.com/cosmos/cosmos-db v1.1.1 | ||
| github.com/cosmos/cosmos-sdk v0.50.14 | ||
| github.com/cosmos/cosmos-sdk v0.50.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High severity vulnerability introduced by a package you're using:
Line 24 lists a dependency (github.com/cosmos/cosmos-sdk) with a known High severity vulnerability. Fixing requires upgrading or replacing the dependency.
ℹ️ Why this matters
Affected versions of github.com/cosmos/cosmos-sdk are vulnerable to Integer Overflow or Wraparound. A malicious validator can exploit improperly handled arithmetic in the distribution module by making a crafted deposit to the validator rewards pool. This integer overflow can trigger a chain halt, resulting in a denial-of-service.
References: GHSA
To resolve this comment:
Upgrade this dependency to at least version 0.50.14 at go.mod.
💬 Ignore this finding
To ignore this, reply with:
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
You can view more details on this finding in the Semgrep AppSec Platform here.
408cb79 to
95204d3
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1a2e845 to
89b1a17
Compare
89b1a17 to
d74a1c9
Compare
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
solution:
update memival,store,versondb
related prs
crypto-org-chain/cronos#1684
crypto-org-chain/cronos#1685
crypto-org-chain/cronos#1688
(Do not include versionDB.SetSkipVersionZero(true) in app.go)
crypto-org-chain/cronos#1751
crypto-org-chain/cronos#1759
(note: Do not include cronos storeloader and upgrades)
note:
I don't use this.
crypto-org-chain/cronos#1780
because it update rocksdbs from version 9.2.1 to 9.11.2
and grocksdb from 1.9.2 to v1.9.10-0.20250331012329-9d5f074653d1
I need to look into the differences.
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)