Skip to content

[WIP] Use cacheed CNI config in pod deletion #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] Use cacheed CNI config in pod deletion #52

wants to merge 1 commit into from

Conversation

@s1061123
Copy link
Contributor

@s1061123 s1061123 commented Jul 26, 2019 •
edited
Loading

  • Create cache in pod addition
  • Use cache in pod deletion
  • Delete the case in pod deletion

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 26, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s1061123
To complete the pull request process, please assign sameo
You can assign the PR to them by writing /assign @sameo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s1061123 s1061123 changed the title [WIP] Use cache CNI config in pod deletion [WIP] Use cacheed CNI config in pod deletion Jul 26, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2019
@s1061123
Copy link
Contributor Author

s1061123 commented Jul 26, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2019
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 26, 2019
@mars1024 mars1024 mentioned this pull request Aug 21, 2019
Closed
@dcbw
Copy link
Collaborator

dcbw commented Aug 28, 2019

@s1061123 I have a different take on this in #52 that works for CHECK too.

@dcbw dcbw closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@s1061123 @openshift-ci-robot @dcbw