Fix Apache Superset Pipeline (#1891)

* Add rich to dependencies

* Update superset and python matrix to test recent versions

* fix pipeline

* Adapt tests for newer superset version

Author: bgunebakan

.github/workflows/application-apache-superset.yml

@@ -54,24 +54,19 @@ jobs:
           # https://github.com/apache/superset/issues/35942
           # - '5.*'
 
-          # Superset 6.x will work without much ado.
-          - '6.0.0rc2'
+          # Superset 6.x stable releases.
+          - '6.0.0'
+          - '6.1.0'
         python-version:
-          - '3.9'
+          - '3.10'
           - '3.11'
+          - '3.12'
         cratedb-version:
           - 'nightly'
 
         exclude:
-          # Apache Superset 6.x no longer supports Python 3.9.
-          - superset-version: "6.0.0rc2"
-            python-version: "3.9"
-
-        include:
-          # Apache Superset 6.x supports Python 3.12.
-          - os: "ubuntu-latest"
-            cratedb-version: "nightly"
-            superset-version: "6.0.0rc2"
+          # Apache Superset 4.x does not support Python 3.12.
+          - superset-version: "4.*"
             python-version: "3.12"
 
 

application/apache-superset/requirements.txt

@@ -1,3 +1,5 @@
 apache-superset
 flask-jwt-extended>=4.7.1
-sqlalchemy-cratedb>=0.42.0.dev2
+sqlalchemy-cratedb>=0.43.1
+rich
+cachetools

application/apache-superset/superset_config.py

@@ -41,3 +41,14 @@
 
 # Set this API key to enable Mapbox visualizations
 MAPBOX_API_KEY = ''
+
+# Superset 6.1+ ships a SQL Lab bundle that calls `eval()` during startup,
+# which the default Content-Security-Policy blocks (missing 'unsafe-eval'),
+# leaving the UI stuck on the loading spinner.
+# https://github.com/apache/superset/blob/6.1.0/superset/config.py
+import copy
+
+from superset.config import TALISMAN_CONFIG as _TALISMAN_CONFIG
+
+TALISMAN_CONFIG = copy.deepcopy(_TALISMAN_CONFIG)
+TALISMAN_CONFIG["content_security_policy"]["script-src"].append("'unsafe-eval'")

application/apache-superset/test.py

@@ -1,4 +1,5 @@
 import requests
+from playwright.sync_api import TimeoutError as PlaywrightTimeoutError
 from playwright.sync_api import expect, sync_playwright
 
 from util import get_auth_headers
@@ -62,22 +63,30 @@ def test_ui():
         # Navigate to Apache Superset.
         page = browser.new_page()
         page.goto(uri_home)
-        page.wait_for_url("**/login/")
+        page.wait_for_url("**/login/**")
 
         # Run the login procedure.
         page.type("input#username", "admin")
         page.type("input#password", "admin")
         page.click("[type=submit]")
         page.wait_for_load_state()
 
-        # Navigate to SQL Lab.
+        # Navigate to SQL Lab. Older Superset versions open a query editor tab
+        # automatically; newer ones (6.1+) start empty and require creating one.
         page.goto(uri_sqllab)
         page.wait_for_load_state()
+        try:
+            page.wait_for_selector(".ace_editor", timeout=5000)
+        except PlaywrightTimeoutError:
+            page.click('[data-test="add-tab-icon"]')
 
         # Invoke query on SQL Lab.
+        # The ace editor's DOM id is randomly generated per tab instance, so
+        # look it up by its `ace_editor` class instead of a fixed element id.
         sql = "SELECT region, mountain, height FROM sys.summits LIMIT 42;"
-        page.wait_for_selector("#ace-editor")
-        page.evaluate(f"ace.edit('ace-editor').setValue('{sql}')")
+        page.wait_for_selector(".ace_editor")
+        editor_id = page.eval_on_selector(".ace_editor", "el => el.id")
+        page.evaluate(f"ace.edit('{editor_id}').setValue('{sql}')")
         page.get_by_role("button", name="Run").click()
         page.wait_for_load_state()