Prepend table preprocessor #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a table is present we need to instruct the groff to enable the table preprocessor. This surpresses warnings from groff. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
tbl_preprocessor
branch
from
92d232d to
b262760
Compare
Collaborator
|
For others; this is easier to review with whitespace disabled in the diff; https://github.com/cpuguy83/go-md2man/pull/111/files?w=1 
|
thaJeztah
approved these changes
Feb 5, 2024
Collaborator
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
"LGTM" but take that with a good grain of salt; code changes look good, but I'm not good at roff, so wouldn't hurt to have more eyes to verify correctness.
|
I hope I qualify as good at roff, but anytime I find myself unable to solve a problem in it with minimal effort, I wonder... The roff change part of this LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a table is present we need to instruct groff to enable the table preprocessor.
This surpresses warnings from groff.
Fixes #99