Skip to content

Commit 813cc91

Browse files
authored
Update tests to support CMake 4 (#698)
* update tests to support cmake 4 * remove version 3.30 in favor of the 3.28.3 (default of second latest Ubuntu LTS release)
1 parent 7d36988 commit 813cc91

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
os: [ubuntu-latest, windows-2022, macos-latest]
2020
# we want to ensure compatibility with a recent CMake version as well as the lowest officially supported
2121
# legacy version that we define as the default version of the second-latest Ubuntu LTS release currently available
22-
cmake_version: ['3.16.3', '3.27.5', '3.30.0']
22+
cmake_version: ['3.16.3', '3.28.3', '4.3.2']
2323
exclude:
2424
# there seems to be an issue with CMake 3.16 not finding a C++ compiler on windows-2022
2525
- os: windows-2022

test/unit/local_dependency/OptionsCMakeLists.txt.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ include(@CPM_PATH@/testing.cmake)
3030
message("DEFINE_ALTERNATIVE_FUNCTION: ${DEFINE_ALTERNATIVE_FUNCTION}")
3131

3232
# this option is overridden by CPM.cmake
33-
ASSERT_NOT_DEFINED(DEFINE_ALTERNATIVE_FUNCTION)
33+
ASSERT_FALSY(DEFINE_ALTERNATIVE_FUNCTION)
3434
# this option is leaked by the dependency
3535
ASSERT_EQUAL(${LEAKED_OPTION} "OFF")

test/unit/local_dependency/dependency/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.0 FATAL_ERROR)
1+
cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
22

33
option(DEFINE_ALTERNATIVE_FUNCTION "define the alternative function" OFF)
44
option(LEAKED_OPTION "this option will be leaked to the outer scope" OFF)

0 commit comments

Comments
 (0)