chore: adding stop relayer func to e2e suite

[damiannolan]

Description

closes: #1974

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[chatton]

if we're creating a separate function then we can probably remove eRep as an argument

func (s *E2ETestSuite) StopRelayer(ctx context.Context, relayer ibc.Relayer) {
	err := relayer.StopRelayer(ctx, s.GetRelayerExecReporter())
        s.Require().NoError(err)
}

[damiannolan]

Nice catch! I'll push an update.

I was thinking it might be an idea to eventually move the ctx onto the E2ETestSuite as well, as I think it's just being retrieved from context.TODO() in most test cases.

[chatton]

yeah atm it's just doing a passthrough to the ibctest functions, but I think having the context at the test level can be useful. It allows for things like timeouts and cancellations. (we just aren't using it for anything atm)

[crodriguezvega]

Does this PR close #1974?

[chatton]

LGTM!

[charleenfei]

lgtm!