Skip to content

chore: don't use ioutil#1920

Merged
colin-axner merged 3 commits intocosmos:mainfrom
notional-labs:no-ioutil
Aug 9, 2022
Merged

chore: don't use ioutil#1920
colin-axner merged 3 commits intocosmos:mainfrom
notional-labs:no-ioutil

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Aug 9, 2022

Description

This PR removes the deprecated io/ioutil library from ibc-go, and replaces it with os.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @faddat

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye, thank you!

@colin-axner colin-axner enabled auto-merge (squash) August 9, 2022 10:05
@colin-axner colin-axner merged commit 8b61fa1 into cosmos:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants