fix: make format and golangci-lint errors#1894
Merged
crodriguezvega merged 6 commits intomainfrom Aug 5, 2022
Merged
Conversation
damiannolan
changed the title
damiannolan
requested review from
AdityaSripal,
charleenfei,
chatton,
colin-axner,
crodriguezvega and
seantking
as code owners
9 tasks
crodriguezvega
approved these changes
Aug 5, 2022
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2022
* removing gofmt from golangci.yml * attempt to fix gofmt interacer lint errors * updating makefile and running gofumpt * adding exception to makefile for misspell, fixing chanOpenConfirm godoc * removing unnecessary -s flag (cherry picked from commit e5ec801)
crodriguezvega
pushed a commit
that referenced
this pull request
Aug 7, 2022
* removing gofmt from golangci.yml * attempt to fix gofmt interacer lint errors * updating makefile and running gofumpt * adding exception to makefile for misspell, fixing chanOpenConfirm godoc * removing unnecessary -s flag (cherry picked from commit e5ec801) Co-authored-by: Damian Nolan <[email protected]>
3 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makefilefrom chore: replacegofmtwithgofumpt#1892gofmtfromgolang-ci-lintin favour ofgofumptTo run locally:
Ensure you have
gofumptinstalled and run the specifiedmaketarget below:closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes