E2E: Fee middleware counterparty payee not set#1746
Conversation
chatton
requested review from
AdityaSripal,
charleenfei,
colin-axner,
crodriguezvega,
damiannolan and
seantking
as code owners
| packetId := channeltypes.NewPacketId(channelA.PortID, channelA.ChannelID, 1) | ||
| packetFee := feetypes.NewPacketFee(testFee, chainAWallet.Bech32Address(chainA.Config().Bech32Prefix), nil) | ||
|
|
||
| t.Run("should succeed", func(t *testing.T) { |
There was a problem hiding this comment.
Maybe something extra in the description to make it more explicit? Like pay packet fee should succeed?
There was a problem hiding this comment.
based on the nesting, the resulting message will look like TestPayPacketFeeAsync_SingleSender_NoCounterPartyAddress/pay_packet_fee/should_succeed
Co-authored-by: Carlos Rodriguez <[email protected]>
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Great work! Looks super clean :)
e2e/fee_middleware_test.go
Outdated
| s.Require().Empty(packets) | ||
| }) | ||
|
|
||
| packetId := channeltypes.NewPacketId(channelA.PortID, channelA.ChannelID, 1) |
There was a problem hiding this comment.
| packetId := channeltypes.NewPacketId(channelA.PortID, channelA.ChannelID, 1) | |
| packetId := channeltypes.NewPacketId(chainATx.Packet.GetSourcePort(), chainATx.Packet.GetSourceChannel(), chainATx.Packet.GetSequence()) |
I think at least modifying the sequence to use the returned chainATx.Packet.GetSequence makes sense, I have no preference on the other arguments, I just figure this code will be copied a lot so might make more sense to derive the values
There was a problem hiding this comment.
ah definitely, good catch.
| var err error | ||
| payPacketFeeTxResp, err = s.PayPacketFeeAsync(ctx, chainA, chainAWallet, packetId, packetFee) | ||
| s.Require().NoError(err) | ||
| s.AssertValidTxResponse(payPacketFeeTxResp) |
There was a problem hiding this comment.
love this helper function ❤️
chatton
deleted the
cian/issue#1686-fee-middleware-counterparty-payee-not-set
branch
4 participants
Description
closes: #1686
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes