fix!: clear expiration queues on revoke (backport #25540) #25541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When removing an entry from the expiration queue,
x/feegrantuses the key with the granter/grantee inverted. The correct key isfeegrant.FeeAllowanceKey(granter, grantee), notfeegrant.FeeAllowanceKey(grantee, granter). This prevents proper deletion of the allowance entry.Patch-style hint
Impact
Expiration not actually removed for the prior grant.
Recreated grant can be deleted later by the leftover (stale) expiration event.
!!!!!! consensus breaking !!!!!!