Skip to content

Conversation

@forkfury
Copy link

@forkfury forkfury commented Nov 4, 2025

Description

Exposes NullSliceAsEmptyEncoder as a public function to allow apps to use it for their own fields.
Adds "null_slice_as_empty" encoding option that can be used in protobuf annotations for any slice type.

Changes:

  • Export NullSliceAsEmptyEncoder function
  • Register "null_slice_as_empty" field encoder (in addition to "legacy_coins")
  • Update documentation with usage examples

Fixes #25222

@github-actions github-actions bot added the C:x/tx label Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.66%. Comparing base (002ae6e) to head (ec42fe1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25539      +/-   ##
==========================================
+ Coverage   68.34%   70.66%   +2.32%     
==========================================
  Files         857      851       -6     
  Lines       55714    55752      +38     
==========================================
+ Hits        38075    39397    +1322     
+ Misses      17639    16355    -1284     
Files with missing lines Coverage Δ
x/tx/signing/aminojson/encoder.go 34.75% <100.00%> (ø)
x/tx/signing/aminojson/json_marshal.go 76.59% <100.00%> (ø)

... and 66 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aljo242
Copy link
Contributor

aljo242 commented Nov 6, 2025

lgtm - can we get a changelog entry and some testing?

@forkfury forkfury requested a review from aljo242 November 13, 2025 09:01
@aljo242 aljo242 enabled auto-merge November 13, 2025 13:30
@aljo242
Copy link
Contributor

aljo242 commented Nov 13, 2025

@forkfury CI is failing

auto-merge was automatically disabled November 13, 2025 19:23

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expose nullSliceAsEmptyEncoder amino field encoder

2 participants