-
Notifications
You must be signed in to change notification settings - Fork 444
fix(dicomImageLoader): use calibrated pixel spacing (if available) when loading DICOM images via WADO-RS #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tblock79
wants to merge
12
commits into
cornerstonejs:main
Choose a base branch
from
tblock79:fix/pixelspacing-projrad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+962
−205
Open
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bbc163c
Setting the calibrated pixel spacing (if available) for images loaded…
vitblock 630b1f5
Removed unused import.
vitblock e2af697
Merge remote-tracking branch 'origin/main' into fix/pixelspacing-projrad
wayfarer3130 c86a22a
fix: Differences between wadors and wadouri
wayfarer3130 9bbc5fa
fix: Start of being able to read pixel spacing appropriately.
wayfarer3130 8a6a34b
Remove an unnecessary fromNatural call
wayfarer3130 21c8230
fix: Working common image plane module - still needs other attrs
wayfarer3130 f0e29b4
fix: Generate US region sequences
wayfarer3130 864b0cd
Set base US region
wayfarer3130 0e86ed3
Support for sequences
wayfarer3130 ce5c94c
Merge remote-tracking branch 'origin/main' into fix/pixelspacing-projrad
wayfarer3130 2276700
docs: Add jsdocs
wayfarer3130 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /** | ||
| * Returns the values as an array of javascript numbers | ||
| * | ||
| * @param val - The javascript object for the specified element in the metadata | ||
| * @returns {*} | ||
| */ | ||
| export function toNumber(val) { | ||
| if (Array.isArray(val)) { | ||
| return [...val].map((v) => (v !== undefined ? Number(v) : v)); | ||
| } else { | ||
| return val !== undefined ? Number(val) : val; | ||
| } | ||
| } | ||
|
|
||
| export default toNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code has been moved to shared code between different types of instance data.