Remove unnecessary stop logic from soundcloud

cookpete · cookpete · commit f478f1a3c29c · 2017-09-15T13:21:51.000+01:00
The widget is an iframe that gets unmounted, so I can't see why pausing and seeking beforehand is necessary
diff --git a/src/players/Facebook.js b/src/players/Facebook.js
@@ -53,7 +53,7 @@ export default class Facebook extends Base {
     this.callPlayer('pause')
   }
   stop () {
-    // No need to stop
+    // Nothing to do
   }
   seekTo (amount) {
     const seconds = super.seekTo(amount)
diff --git a/src/players/SoundCloud.js b/src/players/SoundCloud.js
@@ -70,8 +70,7 @@ export default class SoundCloud extends Base {
     }
   }
   stop () {
-    this.pause()
-    this.callPlayer('seekTo', 0)
+    // Nothing to do
   }
   seekTo (amount) {
     const seconds = super.seekTo(amount)

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ export default class Facebook extends Base {`
`53`	`53`	`this.callPlayer('pause')`
`54`	`54`	`}`
`55`	`55`	`stop () {`
`56`		`- // No need to stop`
	`56`	`+ // Nothing to do`
`57`	`57`	`}`
`58`	`58`	`seekTo (amount) {`
`59`	`59`	`const seconds = super.seekTo(amount)`
Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,7 @@ export default class SoundCloud extends Base {`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`stop () {`
`73`		`- this.pause()`
`74`		`- this.callPlayer('seekTo', 0)`
	`73`	`+ // Nothing to do`
`75`	`74`	`}`
`76`	`75`	`seekTo (amount) {`
`77`	`76`	`const seconds = super.seekTo(amount)`