Skip to content

Commit a55ef3c

Browse files
committed
Remove legacy Soundcloud player
Causes more problems than it solves, and people can just install older versions of ReactPlayer if they really need to Reverts commit 4399d1d
1 parent c16207a commit a55ef3c

4 files changed

Lines changed: 4 additions & 99 deletions

File tree

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@
8888
"whatwg-fetch": "^2.0.1"
8989
},
9090
"dependencies": {
91-
"fetch-jsonp": "^1.0.2",
9291
"load-script": "^1.0.0",
9392
"lodash.omit": "^4.5.0",
9493
"prop-types": "^15.5.6"

src/ReactPlayer.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import omit from 'lodash.omit'
44
import { propTypes, defaultProps } from './props'
55
import YouTube from './players/YouTube'
66
import SoundCloud from './players/SoundCloud'
7-
import SoundCloudLegacy from './players/SoundCloudLegacy'
87
import Vimeo from './players/Vimeo'
98
import Facebook from './players/Facebook'
109
import FilePlayer from './players/FilePlayer'
@@ -82,16 +81,12 @@ export default class ReactPlayer extends Component {
8281
}
8382
renderPlayers () {
8483
// Build array of players to render based on URL and preload config
85-
const { url, youtubeConfig, vimeoConfig, dailymotionConfig, soundcloudConfig } = this.props
84+
const { url, youtubeConfig, vimeoConfig, dailymotionConfig } = this.props
8685
const players = []
8786
if (YouTube.canPlay(url)) {
8887
players.push(YouTube)
8988
} else if (SoundCloud.canPlay(url)) {
90-
if (soundcloudConfig.legacy) {
91-
players.push(SoundCloudLegacy)
92-
} else {
93-
players.push(SoundCloud)
94-
}
89+
players.push(SoundCloud)
9590
} else if (Vimeo.canPlay(url)) {
9691
players.push(Vimeo)
9792
} else if (Facebook.canPlay(url)) {

src/players/SoundCloudLegacy.js

Lines changed: 0 additions & 85 deletions
This file was deleted.

src/props.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ export const propTypes = {
1818
hidden: bool,
1919
className: string,
2020
soundcloudConfig: shape({
21-
options: object,
22-
legacy: bool,
23-
clientId: string
21+
options: object
2422
}),
2523
youtubeConfig: shape({
2624
playerVars: object,
@@ -75,9 +73,7 @@ export const defaultProps = {
7573
progressFrequency: 1000,
7674
playsinline: false,
7775
soundcloudConfig: {
78-
options: {},
79-
legacy: false,
80-
clientId: 'e8b6f84fbcad14c301ca1355cae1dea2'
76+
options: {}
8177
},
8278
youtubeConfig: {
8379
playerVars: {},

0 commit comments

Comments
 (0)