Conversation
507b034 to
8c3c89b
Compare
There was a problem hiding this comment.
Pull request overview
Upgrades the Cookiecutter Django template to target Django 6.0, aligning dependency pins, template settings, and related tooling/configuration with the new major version.
Changes:
- Bump Django pin to
6.0.3and adjust pyup constraint to< 7.0; remove outdated Pillow pyup constraint. - Update
ADMINSsetting format in the generated project settings and adjust generation test expectation accordingly. - Update django-upgrade pre-commit target version and refresh Django version references/classifiers (README + pyproject).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
{{cookiecutter.project_slug}}/requirements/base.txt |
Updates Django pin/pyup constraint and removes outdated Pillow constraint comment. |
{{cookiecutter.project_slug}}/config/settings/base.py |
Changes ADMINS representation for Django 6.0 compatibility. |
{{cookiecutter.project_slug}}/.pre-commit-config.yaml |
Updates django-upgrade target version to 6.0. |
tests/test_cookiecutter_generation.py |
Updates assertion to match new ADMINS formatting in generated settings. |
pyproject.toml |
Updates trove classifier to Django 6.0. |
README.md |
Updates stated supported Django version to 6.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
- Update django 5.2.12 -> 6.0.3 and pyup constraint < 6.0 -> < 7.0 - Update ADMINS setting from deprecated tuple format to string format (tuple format deprecated in Django 6.0) - Update django-upgrade target from 5.2 to 6.0 - Bump factory-boy 3.3.2 -> 3.3.3 - Remove outdated Pillow pyup constraint - Update pyproject.toml Django framework classifier All dependencies verified compatible with Django 6.0: django-celery-beat 2.9.0 (Django<6.1), django-storages 1.14.6, django-allauth 65.14.3, djangorestframework 3.16.1, django-redis 6.0.0, and all others install and pass tests. Ref: cookiecutter#6226
|
There are still a few packages with a red cross on #6226 but most of them are actually running fine under 6.0 (I use most of them on a project). The only exception is django-stubs: We test mypy on the generated project but we don't use a lot of Django features. I wonder if folks will run into frictions into their project after adding stuff because support wouldn't be fully there? On the other hand, a type check issue can be silenced with a comment and hopefully it won't be too long before they release django-stubs 6.0 |
browniebroke
left a comment
There was a problem hiding this comment.
Looks good to me. I didn't see any mentions of dropping Postgres version this time around
Description
Upgrade to Django 6.0 (ref #6226)
Changes
< 6.0->< 7.0Dependency Compatibility
All dependencies verified compatible with Django 6.0, no git installs or constraint overrides needed:
Django<6.1,>=2.2Django>=3.2Testing
cookiecutter --no-input(use_celery=y, rest_api=DRF, use_whitenoise=y)manage.py check: 0 issuesmanage.py migrate: all migrations appliedpytest: 31/31 tests passedChecklist:
Rationale
Django 5.2 enters extended support (security fixes only) while Django 6.0 is now the actively supported release. All dependencies already support Django 6.0 on PyPI — the only blocker was django-celery-beat, which was resolved in their 2.9.0 release (
Django<6.1).Fix #6226
Closes #6233