fix(accessibility): Fix bug with tab reverting to "summary" on map marker drag

David Emory · David Emory · commit ce3d2acee61e · 2018-05-11T18:13:25.000-04:00
diff --git a/lib/manager/components/version/FeedVersionReport.js b/lib/manager/components/version/FeedVersionReport.js
@@ -35,7 +35,8 @@ export default class FeedVersionReport extends Component {
 
   componentWillReceiveProps (nextProps) {
     // Reset tab to summary when version changes
-    if (this.props.version !== nextProps.version) {
+    const { version } = this.props
+    if (version && nextProps.version && version.id !== nextProps.version.id) {
       this.setState({ tab: 'feed' })
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,8 @@ export default class FeedVersionReport extends Component {`
`35`	`35`
`36`	`36`	`componentWillReceiveProps (nextProps) {`
`37`	`37`	`// Reset tab to summary when version changes`
`38`		`- if (this.props.version !== nextProps.version) {`
	`38`	`+ const { version } = this.props`
	`39`	`+ if (version && nextProps.version && version.id !== nextProps.version.id) {`
`39`	`40`	`this.setState({ tab: 'feed' })`
`40`	`41`	`}`
`41`	`42`	`}`