Skip to content

Commit a6b2b6b

Browse files
committed
fix: cubic feedback
1 parent 389664d commit a6b2b6b

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

core/context/mcp/MCPManagerSingleton.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,11 @@ export class MCPManagerSingleton {
2727
conn.status = "not-connected";
2828
await this.refreshConnection(serverId);
2929
} else {
30-
await conn.disconnect(true);
30+
try {
31+
await conn.disconnect(true);
32+
} catch (e) {
33+
console.error(`Error disconnecting from MCP server ${serverId}`, e);
34+
}
3135
}
3236
}
3337
}

core/context/providers/RulesContextProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class RulesContextProvider extends BaseContextProvider {
2222
// This is only used within this class. Worst case if there are exact duplicates is that one always calls the other, but this is an extreme edge case
2323
// Can eventually pull in more metadata, but this is experimental
2424
private getIdFromRule(rule: RuleWithSource): string {
25-
return rule.sourceFile ?? rule.slug ?? rule.name ?? rule.rule;
25+
return rule.slug ?? rule.sourceFile ?? rule.name ?? rule.rule;
2626
}
2727

2828
private getNameFromRule(rule: RuleWithSource): string {

gui/src/components/mainInput/Lump/useEditBlock.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function useEditBlock() {
2525
path: selectedProfile.uri,
2626
});
2727
} else if (
28-
selectedProfile?.fullSlug.ownerSlug &&
28+
selectedProfile?.fullSlug?.ownerSlug &&
2929
selectedProfile?.fullSlug.packageSlug
3030
) {
3131
ideMessenger.post("controlPlane/openUrl", {

gui/src/pages/config/components/ToolPoliciesGroup.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export function ToolPoliciesGroup({
3131
const availableTools = useAppSelector((state) => state.config.config.tools);
3232
const tools = useMemo(() => {
3333
return availableTools.filter((t) => t.group === groupName);
34-
}, [availableTools]);
34+
}, [availableTools, groupName]);
3535

3636
const toolGroupSettings = useAppSelector(
3737
(state) => state.ui.toolGroupSettings,

0 commit comments

Comments
 (0)