fix: revert ReadableStream change

Author: elylucas

MIGRATION.md

@@ -12,14 +12,19 @@
 To upgrade to the latest version of `contentful-management`, use your package manager and then make any necessary changes outlined in the migration guides below.
 
 **npm:**
+
 ```bash
 npm install contentful-management@latest
 ```
+
 **yarn:**
+
 ```bash
 yarn upgrade contentful-management@latest
 ```
+
 **pnpm:**
+
 ```bash
 pnpm update contentful-management@latest
 ```
@@ -49,6 +54,7 @@ If you are affected by any of the items below, follow the upgrade guides in the
 The library now targets ECMAScript 2021, and Babel transpilation for older JavaScript versions has been removed. This means modern JavaScript features like optional chaining (`?.`), nullish coalescing (`??`), and `Promise.any()` are used directly without transpilation.
 
 **Affected environments:**
+
 - Internet Explorer (all versions)
 - Chrome < 85
 - Firefox < 79
@@ -63,6 +69,7 @@ Browser and Node environments that do not support ES2021 might need an additiona
 We dropped support for versions of Node that were no longer LTS and now support Node v20+.
 
 **Compatibility:**
+
 - ✅ Node.js v20+
 - ❌ Node.js v18 and below
 
@@ -85,22 +92,24 @@ And have been replaced with an ESM build for use in modern environments, a Commo
 If you were accessing any of the previous bundles directly, you will need to update to pull from one of the new bundles.
 
 **import example:**
+
 ```javascript
 // Before
-import contentful from './node_modules/contentful-management/dist/contentful-management.node.js';
+import contentful from './node_modules/contentful-management/dist/contentful-management.node.js'
 
 // After (ESM)
-import contentful from 'contentful-management';
+import contentful from 'contentful-management'
 
 // After (CommonJS) - still works
-const contentful = require('contentful-management');
+const contentful = require('contentful-management')
 ```
 
 #### Changes to browser bundle
 
 Browser bundle methods must now be accessed from the `contentfulManagement` object which is added to `window` on load (e.g., `window.contentfulManagement.createClient()`). If you were using methods directly, update your code to destructure them from the `contentfulManagement` object (e.g., `const { createClient } = contentfulManagement`).
 
 **JSDelivr usage:**
+
 ```html
 <!-- Before -->
 <script src="https://cdn.jsdelivr.net/npm/contentful-management@11/dist/contentful-management.browser.min.js"></script>
@@ -122,35 +131,23 @@ All types are exported from both `contentful-management` and `contentful-managem
 **Migration options:**
 
 Option 1 - Update tsconfig.json:
+
 ```json
 {
   "compilerOptions": {
-    "moduleResolution": "node16"  // or "bundler" or "nodenext"
+    "moduleResolution": "node16" // or "bundler" or "nodenext"
   }
 }
 ```
 
 Option 2 - Import from main package:
+
 ```typescript
 // Instead of
-import type { Space } from 'contentful-management/types';
+import type { Space } from 'contentful-management/types'
 
 // Use
-import type { Space } from 'contentful-management';
-```
-
-##### Replaced the `Stream` type with `ReadableStream`
-
-The `Stream` type was specific to Node.js environments and could cause issues in browsers. It has been replaced with `ReadableStream`, which is a global type available in both Node.js and browser environments.
-
-**Migration example:**
-```typescript
-// Before
-import type { Stream } from 'stream';
-function processStream(stream: Stream) { ... }
-
-// After
-function processStream(stream: ReadableStream) { ... }
+import type { Space } from 'contentful-management'
 ```
 
 ### Troubleshooting
@@ -166,6 +163,7 @@ function processStream(stream: ReadableStream) { ... }
 **Cause:** Your TypeScript configuration uses an older module resolution strategy.
 
 **Solution:** Update your `tsconfig.json`:
+
 ```json
 {
   "compilerOptions": {
@@ -180,19 +178,22 @@ Or import types directly from `contentful-management` instead of `contentful-man
 
 **Cause:** Your environment doesn't support ES2021.
 
-**Solution:** 
+**Solution:**
+
 - For Node.js: Upgrade to Node.js v20 or higher
 - For browsers: Ensure you're targeting modern browsers that support ES2021 (Chrome 85+, Firefox 79+, Safari 14+, Edge 85+)
 - Consider using a transpilation tool like Babel if you must support older environments
 
 #### Types not resolving correctly
 
 **Possible causes:**
+
 - Outdated module resolution in `tsconfig.json`
 - IDE needs to be restarted after upgrade
 - Type cache needs to be cleared
 
 **Solutions:**
+
 1. Update `moduleResolution` to `node16` or higher
 2. Restart your IDE/TypeScript server
 3. Delete `node_modules` and reinstall: `rm -rf node_modules && npm install`
@@ -202,4 +203,3 @@ Or import types directly from `contentful-management` instead of `contentful-man
 - Review the [CHANGELOG](CHANGELOG.md) for all changes
 - Check the [README](README.md) for updated usage examples
 - [File an issue](https://github.com/contentful/contentful-management.js/issues) if you encounter problems
-

lib/adapters/REST/endpoints/app-upload.ts

@@ -1,4 +1,5 @@
 import type { AxiosInstance } from 'contentful-sdk-core'
+import type Stream from 'stream'
 import * as raw from './raw'
 import type { GetAppUploadParams, GetOrganizationParams } from '../../../common-types'
 import type { RestEndpoint } from '../types'
@@ -32,7 +33,7 @@ export const del: RestEndpoint<'AppUpload', 'delete'> = (
 export const create: RestEndpoint<'AppUpload', 'create'> = (
   http: AxiosInstance,
   params: GetOrganizationParams,
-  payload: { file: string | ArrayBuffer | ReadableStream },
+  payload: { file: string | ArrayBuffer | Stream },
 ) => {
   const httpUpload = getUploadHttpClient(http)
 

lib/adapters/REST/endpoints/upload.ts

@@ -1,4 +1,5 @@
 import type { AxiosInstance } from 'contentful-sdk-core'
+import type Stream from 'stream'
 import type {
   GetSpaceEnvironmentParams,
   GetSpaceEnvironmentUploadParams,
@@ -22,7 +23,7 @@ const getEntityUploadUrl = (params: GetSpaceEnvironmentUploadParams) => {
 export const create: RestEndpoint<'Upload', 'create'> = (
   http: AxiosInstance,
   params: GetSpaceEnvironmentParams,
-  data: { file: string | ArrayBuffer | ReadableStream },
+  data: { file: string | ArrayBuffer | Stream },
 ) => {
   const httpUpload = getUploadHttpClient(http)
 

lib/common-types.ts

@@ -1,5 +1,6 @@
 import type { RawAxiosRequestConfig, RawAxiosRequestHeaders } from 'axios'
 import type { OpPatch } from 'json-patch'
+import type Stream from 'stream'
 import type {
   AccessTokenProps,
   CreatePersonalAccessTokenProps as CreatePATProps,
@@ -1140,7 +1141,7 @@ export type MRActions = {
     }
     create: {
       params: GetOrganizationParams
-      payload: { file: string | ArrayBuffer | ReadableStream }
+      payload: { file: string | ArrayBuffer | Stream }
       return: AppUploadProps
     }
   }
@@ -2226,7 +2227,7 @@ export type MRActions = {
     get: { params: GetSpaceEnvironmentUploadParams; return: any }
     create: {
       params: GetSpaceEnvironmentParams
-      payload: { file: string | ArrayBuffer | ReadableStream }
+      payload: { file: string | ArrayBuffer | Stream }
       return: any
     }
     delete: { params: GetSpaceEnvironmentUploadParams; return: any }

lib/create-environment-api.ts

@@ -60,6 +60,7 @@ import type { CreateAppAccessTokenProps } from './entities/app-access-token'
 import type { ResourceQueryOptions } from './entities/resource'
 import type { AiActionInvocationType } from './entities/ai-action-invocation'
 import { wrapAiActionInvocation } from './entities/ai-action-invocation'
+import type Stream from 'stream'
 
 /**
  * @private
@@ -1195,7 +1196,7 @@ export default function createEnvironmentApi(makeRequest: MakeRequest) {
      * .catch(console.error)
      * ```
      */
-    createUpload: function createUpload(data: { file: string | ArrayBuffer | ReadableStream }) {
+    createUpload: function createUpload(data: { file: string | ArrayBuffer | Stream }) {
       const raw = this.toPlainObject() as EnvironmentProps
       return makeRequest({
         entityType: 'Upload',

lib/create-organization-api.ts

@@ -1,4 +1,5 @@
 import { createRequestConfig } from 'contentful-sdk-core'
+import type Stream from 'stream'
 import entities from './entities'
 import type { CreateTeamMembershipProps } from './entities/team-membership'
 import type { CreateTeamProps } from './entities/team'
@@ -663,7 +664,7 @@ export default function createOrganizationApi(makeRequest: MakeRequest) {
      * .catch(console.error)
      * ```
      */
-    createAppUpload(file: string | ArrayBuffer | ReadableStream) {
+    createAppUpload(file: string | ArrayBuffer | Stream) {
       const raw = this.toPlainObject() as OrganizationProps
 
       return makeRequest({

lib/entities/asset.ts

@@ -1,5 +1,6 @@
 import copy from 'fast-copy'
 import { freezeSys, toPlainObject } from 'contentful-sdk-core'
+import type Stream from 'stream'
 import enhanceWithMethods from '../enhance-with-methods'
 import type {
   MetaSysProps,
@@ -47,7 +48,7 @@ export interface AssetFileProp {
     description: { [key: string]: string }
     file: {
       [key: string]: {
-        file: string | ArrayBuffer | ReadableStream
+        file: string | ArrayBuffer | Stream
         contentType: string
         fileName: string
       }

lib/plain/entities/app-upload.ts

@@ -1,6 +1,7 @@
 import type { GetAppUploadParams, GetOrganizationParams } from '../../common-types'
 import type { AppUploadProps } from '../../entities/app-upload'
 import type { OptionalDefaults } from '../wrappers/wrap'
+import type Stream from 'stream'
 
 export type AppUploadPlainClientAPI = {
   /**
@@ -51,6 +52,6 @@ export type AppUploadPlainClientAPI = {
    */
   create(
     params: OptionalDefaults<GetOrganizationParams>,
-    payload: { file: string | ArrayBuffer | ReadableStream },
+    payload: { file: string | ArrayBuffer | Stream },
   ): Promise<AppUploadProps>
 }

lib/plain/entities/upload.ts

@@ -1,3 +1,4 @@
+import type Stream from 'stream'
 import type { OptionalDefaults } from '../wrappers/wrap'
 import type { GetSpaceEnvironmentParams, GetSpaceEnvironmentUploadParams } from '../../common-types'
 
@@ -39,7 +40,7 @@ export type UploadPlainClientAPI = {
    */
   create(
     params: OptionalDefaults<GetSpaceEnvironmentParams>,
-    data: { file: string | ArrayBuffer | ReadableStream },
+    data: { file: string | ArrayBuffer | Stream },
   ): Promise<any>
   /** Deletes the Space Environment Upload
    *