Skip to content

add boolean return value to SparkEventListener that controls animation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connyduck merged 2 commits into from
Mar 2, 2020
Merged

add boolean return value to SparkEventListener that controls animation #2

connyduck merged 2 commits into from
Mar 2, 2020

Conversation

@connyduck
Copy link
Owner

@connyduck connyduck commented Feb 7, 2020

No description provided.

@connyduck connyduck mentioned this pull request Feb 7, 2020
Merged
@charlag
Copy link

charlag commented Feb 9, 2020

This is a breaking change for two reasons:

  1. New return value
  2. Value passed to the event listener is different now (because it's old value now)

@connyduck connyduck merged commit ab06bbc into master Mar 2, 2020
@connyduck connyduck deleted the make_event_listener_conditional branch June 20, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connyduck @charlag