build: MSVC: fixed linking with OpenSSL#5334
Open
Marat Abrarov (mabrarov) wants to merge 1 commit intoconfluentinc:masterfrom
Open
build: MSVC: fixed linking with OpenSSL#5334Marat Abrarov (mabrarov) wants to merge 1 commit intoconfluentinc:masterfrom
Marat Abrarov (mabrarov) wants to merge 1 commit intoconfluentinc:masterfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Signed-off-by: Marat Abrarov <[email protected]>
Marat Abrarov (mabrarov)
force-pushed
the
feature/msvc_openssl
branch
from
38dc2f1 to
f504170
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of changes from fluent/fluent-bit#11397.
Changes:
dsuffix in its name when built for / with MSVC. Correct OpenSSL libraries are already added into linker options by CMake project which uses FindOpenSSL CMake module:librdkafka/CMakeLists.txt
Line 110 in 901af7c
pragmaadded in Use vcpkgs for dependencies on Windows #3490 (https://github.com/confluentinc/librdkafka/pull/3490/changes#r2864071512).