-
-
Notifications
You must be signed in to change notification settings - Fork 40
Clean up dependencies #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Can we please keep |
OK, if you have that preference, I don't mind. (by default, I try to harmonize the build system across platforms with ninja where possible; one less divergence to handle). |
|
Hm, seems the |
windows needs it too; remove bound now that output is versioned
only zlib's <FOO>_ROOT is being checked for LLVMConfig, see https://github.com/llvm/llvm-project/blob/llvmorg-16.0.0-rc4/llvm/cmake/modules/LLVMConfig.cmake.in#L70-L84
the link check may misreport that these aren't used, because it cannot inspect static libraries
…nda-forge-pinning 2023.03.16.22.03.16
|
Thanks for the help with 367a295 Isuru, much better than what I was trying to do in conda-forge/llvmdev-feedstock#204, obviously. I've looked a bit more closely how the native config is being built in upstream cross-compilation, and it's basically a normal CMake invocation; this also explains why In any case, this should now be more consistent, both internally and with our llvmdev builds. There shouldn't be any surprises here, but let me know if you want some time to review at your leisure. |
|
Included in #206 |
No description provided.