new tests for options and settings negation (#18306)

Author: memsharded

test/integration/options/options_in_requirements_test.py

@@ -1,13 +1,11 @@
 import textwrap
-import unittest
-
 
 import pytest
 
 from conan.test.utils.tools import TestClient, GenConanfile
 
 
-class OptionsTest(unittest.TestCase):
+class TestOptions:
 
     def test_general_scope_options_test_package(self):
         client = TestClient()
@@ -21,34 +19,34 @@ def configure(self):
         test = GenConanfile().with_test("pass")
         client.save({"conanfile.py": conanfile})
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o *:shared=1")
-        self.assertIn("pkg/0.1@user/testing: BUILD SHARED: 1", client.out)
+        assert "pkg/0.1@user/testing: BUILD SHARED: 1" in client.out
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o shared=2")
         assert 'legacy: Unscoped option definition is ambiguous' in client.out
-        self.assertIn("pkg/0.1@user/testing: BUILD SHARED: 2", client.out)
+        assert "pkg/0.1@user/testing: BUILD SHARED: 2" in client.out
         # With test_package
         client.save({"conanfile.py": conanfile,
                      "test_package/conanfile.py": test})
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o *:shared=1")
-        self.assertIn("pkg/0.1@user/testing: BUILD SHARED: 1", client.out)
+        assert "pkg/0.1@user/testing: BUILD SHARED: 1" in client.out
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o pkg*:shared=2")
-        self.assertIn("pkg/0.1@user/testing: BUILD SHARED: 2", client.out)
+        assert "pkg/0.1@user/testing: BUILD SHARED: 2" in client.out
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o shared=1")
-        self.assertIn("pkg/0.1@user/testing: BUILD SHARED: 1", client.out)
+        assert "pkg/0.1@user/testing: BUILD SHARED: 1" in client.out
 
     def test_general_scope_options_test_package_notdefined(self):
         client = TestClient()
         conanfile = GenConanfile()
         client.save({"conanfile.py": conanfile})
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o *:shared=True")
-        self.assertIn("pkg/0.1@user/testing: Forced build from source", client.out)
+        assert "pkg/0.1@user/testing: Forced build from source" in client.out
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o shared=False", assert_error=True)
-        self.assertIn("option 'shared' doesn't exist", client.out)
+        assert "option 'shared' doesn't exist" in client.out
         # With test_package
         client.save({"conanfile.py": conanfile,
                      "test_package/conanfile.py": GenConanfile().with_test("pass")})
         client.run("create . --name=pkg --version=0.1 --user=user --channel=testing -o *:shared=True")
-        self.assertIn("pkg/0.1@user/testing: Forced build from source", client.out)
-        self.assertIn("Testing the package: Building", client.out)
+        assert "pkg/0.1@user/testing: Forced build from source" in client.out
+        assert "Testing the package: Building" in client.out
 
     def test_general_scope_priorities(self):
         client = TestClient()
@@ -63,23 +61,23 @@ def configure(self):
         client.save({"conanfile.py": conanfile})
         # Consumer has priority
         client.run("create . --name=pkg --version=0.1 -o *:shared=1 -o shared=2 -o p*:other=4")
-        self.assertIn("pkg/0.1: BUILD SHARED: 2 OTHER: 4", client.out)
+        assert "pkg/0.1: BUILD SHARED: 2 OTHER: 4" in client.out
         # Consumer has priority over pattern, even if the pattern specifies the package name
         client.run("create . --name=pkg --version=0.1 -o *:shared=1 -o pkg/*:shared=2 -o shared=3 -o p*:other=4")
-        self.assertIn("pkg/0.1: BUILD SHARED: 3 OTHER: 4", client.out)
+        assert "pkg/0.1: BUILD SHARED: 3 OTHER: 4" in client.out
         client.run("create . --name=pkg --version=0.1 -o pkg/0.1:shared=2 -o p*:other=4 -o pk*:other=5")
-        self.assertIn("pkg/0.1: BUILD SHARED: 2 OTHER: 5", client.out)
+        assert "pkg/0.1: BUILD SHARED: 2 OTHER: 5" in client.out
 
         # With test_package
         client.save({"conanfile.py": conanfile,
                      "test_package/conanfile.py": GenConanfile().with_test("pass")})
         # Sorted (longest, alphabetical) patterns, have priority
         client.run("create . --name=pkg --version=0.1 -o *:shared=1 -o pkg/0.1:shared=2 -o other=4")
-        self.assertIn("pkg/0.1: BUILD SHARED: 2 OTHER: 4", client.out)
+        assert "pkg/0.1: BUILD SHARED: 2 OTHER: 4" in client.out
         client.run("create . --name=pkg --version=0.1 -o pk*:shared=2 -o p*:shared=1 -o pkg/0.1:other=5")
-        self.assertIn("pkg/0.1: BUILD SHARED: 1 OTHER: 5", client.out)
+        assert "pkg/0.1: BUILD SHARED: 1 OTHER: 5" in client.out
         client.run("create . --name=pkg --version=0.1 -o pk*:shared=2 -o p*:shared=1 -o pkg/0.1:other=5 -o *g*:other=6")
-        self.assertIn("pkg/0.1: BUILD SHARED: 1 OTHER: 6", client.out)
+        assert "pkg/0.1: BUILD SHARED: 1 OTHER: 6" in client.out
 
     def test_parsing(self):
         client = TestClient()
@@ -104,7 +102,7 @@ def build(self):
 '''
         client.save({"conanfile.txt": conanfile}, clean_first=True)
         client.run("install . --build=missing")
-        self.assertIn("OPTION a=b", client.out)
+        assert "OPTION a=b" in client.out
 
     def test_general_scope_options(self):
         # https://github.com/conan-io/conan/issues/2538
@@ -119,7 +117,7 @@ def configure(self):
                 """)
         client.save({"conanfile.py": conanfile_liba})
         client.run("create . --name=liba --version=0.1 --user=danimtb --channel=testing -o *:shared=True")
-        self.assertIn("liba/0.1@danimtb/testing: shared=True", client.out)
+        assert "liba/0.1@danimtb/testing: shared=True" in client.out
 
         conanfile_libb = textwrap.dedent("""
             from conan import ConanFile
@@ -141,16 +139,16 @@ def configure(self):
 
             # Test info
             client.run("graph info . -o *:shared=True")
-            self.assertIn("conanfile.py: shared=True", client.out)
-            self.assertIn("liba/0.1@danimtb/testing: shared=True", client.out)
+            assert "conanfile.py: shared=True" in client.out
+            assert "liba/0.1@danimtb/testing: shared=True" in client.out
             # Test create
             client.run("create . --name=libb --version=0.1 --user=danimtb --channel=testing -o *:shared=True")
-            self.assertIn("libb/0.1@danimtb/testing: shared=True", client.out)
-            self.assertIn("liba/0.1@danimtb/testing: shared=True", client.out)
+            assert "libb/0.1@danimtb/testing: shared=True" in client.out
+            assert "liba/0.1@danimtb/testing: shared=True" in client.out
             # Test install
             client.run("install . -o *:shared=True")
-            self.assertIn("conanfile.py: shared=True", client.out)
-            self.assertIn("liba/0.1@danimtb/testing: shared=True", client.out)
+            assert "conanfile.py: shared=True" in client.out
+            assert "liba/0.1@danimtb/testing: shared=True" in client.out
 
     def test_define_nested_option_not_freeze(self):
         c = TestClient()
@@ -611,6 +609,46 @@ def configure(self):
     assert "dep3/0.1@user/channel: MYOPTION: 1" in c.out
 
 
+def test_package_options_negate_patterns():
+    c = TestClient()
+    conanfile = textwrap.dedent("""
+        from conan import ConanFile
+        class Dep(ConanFile):
+            version = "0.1"
+            options = {"myoption": [1, 2, 3]}
+            def build(self):
+                self.output.info(f"MYOPTION={self.options.myoption}!!!")
+            """)
+    c.save({"dep/conanfile.py": conanfile,
+            "pkg/conanfile.py": GenConanfile().with_requires("dep1/0.1", "dep2/0.1", "dep3/0.1")})
+    c.run("export dep --name=dep1")
+    c.run("export dep --name=dep2")
+    c.run("export dep --name=dep3")
+
+    c.run("install pkg --build=* -o *:myoption=1 -o ~dep1/*:myoption=2")
+    assert "dep1/0.1: MYOPTION=1!!!" in c.out
+    assert "dep2/0.1: MYOPTION=2!!!" in c.out
+    assert "dep3/0.1: MYOPTION=2!!!" in c.out
+
+    # Order does matter for options with *:myoption patter, evaluates last
+    c.run("install pkg --build=* -o ~dep1/*:myoption=2 -o *:myoption=1")
+    assert "dep1/0.1: MYOPTION=1!!!" in c.out
+    assert "dep2/0.1: MYOPTION=1!!!" in c.out
+    assert "dep3/0.1: MYOPTION=1!!!" in c.out
+
+    # dep3 comes later, works
+    c.run("install pkg --build=* -o *:myoption=1 -o ~dep1/*:myoption=2 -o dep3/*:myoption=3")
+    assert "dep1/0.1: MYOPTION=1!!!" in c.out
+    assert "dep2/0.1: MYOPTION=2!!!" in c.out
+    assert "dep3/0.1: MYOPTION=3!!!" in c.out
+
+    # dep3 comes first, then last !dep1 pattern prevails
+    c.run("install pkg --build=* -o *:myoption=1 -o dep3/*:myoption=3 -o ~dep1/*:myoption=2")
+    assert "dep1/0.1: MYOPTION=1!!!" in c.out
+    assert "dep2/0.1: MYOPTION=2!!!" in c.out
+    assert "dep3/0.1: MYOPTION=2!!!" in c.out
+
+
 class TestTransitiveOptionsSharedInvisible:
     """
     https://github.com/conan-io/conan/issues/13854

test/integration/options/options_test.py

@@ -1,12 +1,13 @@
+import os
 import textwrap
-import unittest
 
 from parameterized import parameterized
 
+from conan.test.assets.genconanfile import GenConanfile
 from conan.test.utils.tools import TestClient
 
 
-class ConfigureOptionsTest(unittest.TestCase):
+class TestConfigureOptions:
     """
     Test config_options(), configure() and package_id() methods can manage shared, fPIC and
     header_only options automatically.
@@ -50,9 +51,9 @@ def build(self):
         client.save({"conanfile.py": conanfile})
         client.run(f"create . --name=pkg --version=0.1 -s os={settings_os}")
         result = f"shared: {result[0]}, fPIC: {result[1]}, header only: {result[2]}"
-        self.assertIn(result, client.out)
+        assert result in client.out
         if header_only:
-            self.assertIn("Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created", client.out)
+            assert "Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created"in client.out
 
     @parameterized.expand([
         ["Linux", False, False, False, [False, False, False]],
@@ -102,9 +103,9 @@ def build(self):
         client.save({"conanfile.py": conanfile})
         client.run(f"create . --name=pkg --version=0.1 -s os={settings_os}")
         result = f"shared: {result[0]}, fPIC: {result[1]}, header only: {result[2]}"
-        self.assertIn(result, client.out)
+        assert result in client.out
         if header_only:
-            self.assertIn("Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created", client.out)
+            assert "Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created"in client.out
 
     def test_header_package_type_pid(self):
         """
@@ -122,7 +123,7 @@ class Pkg(ConanFile):
                 """)
         client.save({"conanfile.py": conanfile})
         client.run(f"create . --name=pkg --version=0.1")
-        self.assertIn("Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created", client.out)
+        assert "Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created" in client.out
 
 
 def test_config_options_override_behaviour():
@@ -149,3 +150,30 @@ def build(self):
 
     tc.run("create . -o=&:foo=3")
     assert "Foo: 3" in tc.out
+
+
+def test_configure_transitive_option():
+    c = TestClient(light=True)
+    c.save({"conanfile.py": GenConanfile("zlib", "0.1").with_shared_option(False)})
+    c.run("create . -o *:shared=True")
+
+    boost = textwrap.dedent("""
+        from conan import ConanFile
+
+        class BoostConan(ConanFile):
+            name = "boostdbg"
+            version = "1.0"
+            options = {"shared": [True, False]}
+            default_options ={"shared": False}
+            requires = "zlib/0.1"
+
+            def configure(self):
+                self.options["zlib/*"].shared = self.options.shared
+        """)
+
+    c.save({"conanfile.py": boost}, clean_first=True)
+    c.run("create .  -o boostdbg/*:shared=True")
+    # It doesn't fail due to missing binary, as it assigned dependency shared=True
+    pkg_folder = c.created_layout().package()
+    conaninfo = c.load(os.path.join(pkg_folder, "conaninfo.txt"))
+    assert "shared=True" in conaninfo