refactor: migrate user-agent packages to TS (#1393)

* refactor: migrate user-agent packages to TS

* fix: use ts-jest

* fix: lint errors

* fix: tests

* fix: more lint errors

* fix: more lint errors

* chore: do not generate package-lock when installing packages for integration tests

* refactor: use regex literal

* refactor: to remove unnecessary assertion about meta dates

Author: emmenko

.eslintignore

@@ -1,3 +1,4 @@
+credentials.js
 coverage/*
 **/coverage/*
 dist/*
@@ -10,3 +11,4 @@ scripts/*
 **/scripts/*
 node_modules/*
 **/node_modules/*
+**/typescript-sdk/*

.prettierrc

@@ -1,5 +1,14 @@
 {
   "semi": false,
   "trailingComma": "es5",
-  "singleQuote": true
-}
+  "singleQuote": true,
+  "parser": "babel-flow",
+  "overrides": [
+    {
+      "files": "*.ts",
+      "options": {
+        "parser": "typescript"
+      }
+    }
+  ]
+}

TODOS.md

@@ -6,3 +6,4 @@
 | packages/product-json-to-csv/test/writer.spec.js | 263 | the "unzip" package fires finish event before entry events
 | packages/product-json-to-csv/test/writer.spec.js | 308 | the "unzip" package fires finish event before entry events
 | packages/sync-actions/src/utils/diffpatcher.js | 3 | create an issue here https://github.com/benjamine/jsondiffpatch/issues/new
+| /Users/emmenko/dev/src/nodejs/packages/custom-objects-importer/src/main.js | 127 | remove `FlowFixMe` when [this](https://github.com/facebook/flow/issues/5294) issue is fixed

eslint-import-resolver-local.js

@@ -1,4 +1,4 @@
-/* eslint-disable strict,no-param-reassign */
+/* eslint-disable import/no-extraneous-dependencies,strict,no-param-reassign */
 
 // THIS FILE IS COPIED FROM jest
 // https://github.com/facebook/jest/blob/master/eslintImportResolver.js

integration-tests/cli/csv-parser-orders.it.js

@@ -39,42 +39,42 @@ describe('CSV and CLI Tests', () => {
   })
 
   describe('CLI logs specific errors', () => {
-    it('on faulty CSV format', async () => {
+    it('on faulty CSV format', () => {
       const csvFilePath = path.join(samplesFolder, 'faulty-sample.csv')
       const jsonFilePath = tmp.fileSync().name
 
-      expect(
+      return expect(
         exec(`${binPath} -i ${csvFilePath} -o ${jsonFilePath} -t returninfo`)
-      ).rejects.toThrowError(/Row length does not match headers/)
+      ).rejects.toThrow(/Row length does not match headers/)
     })
 
-    it('on missing return-info headers', async () => {
+    it('on missing return-info headers', () => {
       const csvFilePath = path.join(
         samplesFolder,
         'return-info-error2-sample.csv'
       )
       const jsonFilePath = tmp.fileSync().name
 
-      expect(
+      return expect(
         exec(`${binPath} -i ${csvFilePath} -o ${jsonFilePath} -t returninfo`)
-      ).rejects.toThrowError(/Required headers missing: 'orderNumber'/)
+      ).rejects.toThrow(/Required headers missing: 'orderNumber'/)
     })
 
-    it('on missing line-item-state headers', async () => {
+    it('on missing line-item-state headers', () => {
       const csvFilePath = path.join(samplesFolder, 'return-info-sample.csv')
       const jsonFilePath = tmp.fileSync().name
 
-      expect(
+      return expect(
         exec(`${binPath} -i ${csvFilePath} -o ${jsonFilePath} -t lineitemstate`)
-      ).rejects.toThrowError(/Required headers missing: 'fromState,toState'/)
+      ).rejects.toThrow(/Required headers missing: 'fromState,toState'/)
     })
 
-    it('stack trace on verbose level', async () => {
+    it('stack trace on verbose level', () => {
       const csvFilePath = path.join(samplesFolder, 'faulty-sample.csv')
 
-      expect(
+      return expect(
         exec(`${binPath} -i ${csvFilePath} --logLevel verbose -t returninfo`)
-      ).rejects.toThrowError(/ERR: Row length does not match headers/)
+      ).rejects.toThrow(/ERR: Row length does not match headers/)
     })
   })
 
@@ -148,16 +148,16 @@ describe('CSV and CLI Tests', () => {
       expect(data).toMatchSnapshot()
     })
 
-    it('CLI should log errors to stderr and log file', async () => {
+    it('CLI should log errors to stderr and log file', () => {
       const tmpFile = tmp.fileSync()
       const expectedError = 'Row length does not match headers'
       const csvFilePath = path.join(samplesFolder, 'faulty-sample.csv')
 
-      expect(
+      return expect(
         exec(
           `${binPath} -t deliveries --inputFile ${csvFilePath} --logFile ${tmpFile.name}`
         )
-      ).rejects.toThrowError(expectedError)
+      ).rejects.toThrow(expectedError)
     })
   })
 })

integration-tests/cli/csv-parser-price.it.js

@@ -60,13 +60,13 @@ describe('CSV and CLI Tests', () => {
   })
 
   describe('CLI logs specific errors', () => {
-    it('on faulty CSV format', async () => {
+    it('on faulty CSV format', () => {
       const csvFilePath = path.join(samplesFolder, 'faulty-sample.csv')
       const jsonFilePath = tmp.fileSync().name
 
-      expect(
+      return expect(
         exec(`${binPath} -p ${projectKey} -i ${csvFilePath} -o ${jsonFilePath}`)
-      ).rejects.toThrowError(/Row length does not match headers/)
+      ).rejects.toThrow(/Row length does not match headers/)
     })
 
     it('on parsing errors', async () => {
@@ -104,7 +104,7 @@ describe('CSV and CLI Tests', () => {
         exec(
           `${binPath} -p ${projectKey}  -i ${csvFilePath} --logFile ${tmpFile.name}`
         )
-      ).rejects.toThrowError(expectedError)
+      ).rejects.toThrow(expectedError)
 
       const data = await fs.readFile(tmpFile.name, { encoding: 'utf8' })
       expect(data).toContain(expectedError)

integration-tests/cli/discount-codes.it.js

@@ -195,9 +195,6 @@ describe('DiscountCode tests', () => {
   })
 
   describe('Discount Code Exporter', () => {
-    const UTCDateTimeRegex = new RegExp(
-      /[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{3}Z/g
-    )
     let preparedDiscountCodes
     const bin = './integration-tests/node_modules/.bin/discount-code-exporter'
 
@@ -261,8 +258,6 @@ describe('DiscountCode tests', () => {
       actual.forEach(codeObj => {
         expect(codeObj).toMatchObject(expected)
         expect(isuuid(codeObj.id)).toBe(true)
-        expect(codeObj.createdAt).toMatch(UTCDateTimeRegex)
-        expect(codeObj.lastModifiedAt).toMatch(UTCDateTimeRegex)
       })
     })
 

integration-tests/cli/product-export.it.js

@@ -39,7 +39,7 @@ describe('Product Exporter', () => {
 
       await expect(
         exec(`${bin} -o ${filePath} -p ${projectKey} --staged`)
-      ).rejects.toThrowError('No products found')
+      ).rejects.toThrow('No products found')
     })
   })
 

integration-tests/cli/product-json-to-csv.it.js

@@ -512,8 +512,6 @@ describe('CSV and CLI Tests', () => {
         const fileNames = []
         let csvContents1 = ''
         let csvContents2 = ''
-        let stdout
-        let stderr
 
         beforeAll(async done => {
           const zipFile = tmp.fileSync({ postfix: '.zip' }).name
@@ -782,8 +780,6 @@ describe('CSV and CLI Tests', () => {
         const templateFile = `${__dirname}/helpers/product-headers.csv`
         let csvFile
         let products = []
-        let stdout
-        let stderr
 
         beforeAll(async () => {
           csvFile = tmp.fileSync({ postfix: '.csv' }).name

integration-tests/cli/product-json-to-xlsx.it.js

@@ -44,17 +44,6 @@ function mapRowsToProducts(rows) {
   return _rows.map(row => zipObject(header, row))
 }
 
-function analyzeExcelStream(stream) {
-  const workbook = new Excel.Workbook()
-  const readStream = workbook.xlsx.createInputStream()
-  stream.pipe(readStream)
-
-  return new Promise((resolve, reject) => {
-    readStream.on('error', reject)
-    readStream.on('done', () => resolve(analyzeExcelWorkbook(workbook)))
-  })
-}
-
 function analyzeExcelWorkbook(workbook) {
   const rows = []
   const worksheet = workbook.getWorksheet('Products')
@@ -70,11 +59,22 @@ function analyzeExcelWorkbook(workbook) {
   }
 }
 
-async function analyzeExcelFile(path) {
+function analyzeExcelStream(stream) {
+  const workbook = new Excel.Workbook()
+  const readStream = workbook.xlsx.createInputStream()
+  stream.pipe(readStream)
+
+  return new Promise((resolve, reject) => {
+    readStream.on('error', reject)
+    readStream.on('done', () => resolve(analyzeExcelWorkbook(workbook)))
+  })
+}
+
+async function analyzeExcelFile(filePath) {
   const workbook = new Excel.Workbook()
-  await workbook.xlsx.readFile(path)
+  await workbook.xlsx.readFile(filePath)
   return {
-    path,
+    filePath,
     ...(await analyzeExcelWorkbook(workbook)),
   }
 }
@@ -532,8 +532,6 @@ describe('XLSX and CLI Tests', () => {
       describe('WITHOUT HEADERS::should write products to `zip` file', () => {
         let product1
         let product2
-        let stdout
-        let stderr
         const fileNames = []
 
         beforeAll(async done => {
@@ -791,8 +789,6 @@ describe('XLSX and CLI Tests', () => {
         let xlsxFile
         let excel
         let products
-        let stdout
-        let stderr
 
         beforeAll(async () => {
           xlsxFile = tmp.fileSync({ postfix: '.xlsx' }).name