Active at tip failure

Author: patrick-ogrady

reconciler/reconciler.go

@@ -53,12 +53,12 @@ const (
 	// BacklogFull is when the reconciliation backlog is full.
 	BacklogFull = "BACKLOG_FULL"
 
-	// TransientFailure is returned when looking up the live
+	// TipFailure is returned when looking up the live
 	// balance fails but we are at tip. This usually occurs
 	// when the node processes an re-org that we have yet
 	// to process (so the index we are querying at may be
 	// ahead of the nodes tip).
-	TransientFailure = "TRANSIENT_FAILURE"
+	TipFailure = "TIP_FAILURE"
 )
 
 const (
@@ -799,7 +799,7 @@ func (r *Reconciler) reconcileActiveAccounts(ctx context.Context) error { // nol
 						ActiveReconciliation,
 						balanceChange.Account,
 						balanceChange.Currency,
-						TransientFailure,
+						TipFailure,
 					); err != nil {
 						return err
 					}
@@ -930,7 +930,7 @@ func (r *Reconciler) reconcileInactiveAccounts(
 						InactiveReconciliation,
 						nextAcct.Entry.Account,
 						nextAcct.Entry.Currency,
-						TransientFailure,
+						TipFailure,
 					); err != nil {
 						return err
 					}

reconciler/reconciler_test.go

@@ -2205,3 +2205,75 @@ func TestReconcile_EnqueueCancel(t *testing.T) {
 	mockHelper.AssertExpectations(t)
 	mockHandler.AssertExpectations(t)
 }
+
+func TestReconcile_ActiveAtTipError(t *testing.T) {
+	var (
+		block = &types.BlockIdentifier{
+			Hash:  "block 1",
+			Index: 1,
+		}
+		accountCurrency = &types.AccountCurrency{
+			Account: &types.AccountIdentifier{
+				Address: "addr 1",
+			},
+			Currency: &types.Currency{
+				Symbol:   "BTC",
+				Decimals: 8,
+			},
+		}
+	)
+
+	mockHelper := &mocks.Helper{}
+	mockHandler := &mocks.Handler{}
+	r := New(
+		mockHelper,
+		mockHandler,
+		nil,
+		WithActiveConcurrency(1),
+		WithInactiveConcurrency(0),
+		WithLookupBalanceByBlock(),
+	)
+	ctx := context.Background()
+	ctx, cancel := context.WithCancel(ctx)
+
+	mockHelper.On(
+		"LiveBalance",
+		mock.Anything,
+		accountCurrency.Account,
+		accountCurrency.Currency,
+		int64(1),
+	).Return(
+		nil,
+		nil,
+		errors.New("blah"),
+	).Once()
+	mockHelper.On("AtTip", mock.Anything).Return(true, nil).Once()
+	mockHandler.On(
+		"ReconciliationSkipped",
+		mock.Anything,
+		ActiveReconciliation,
+		accountCurrency.Account,
+		accountCurrency.Currency,
+		TipFailure,
+	).Return(nil).Once()
+
+	go func() {
+		err := r.Reconcile(ctx)
+		assert.True(t, errors.Is(err, context.Canceled))
+	}()
+
+	err := r.QueueChanges(ctx, block, []*parser.BalanceChange{
+		{
+			Account:  accountCurrency.Account,
+			Currency: accountCurrency.Currency,
+			Block:    block,
+		},
+	})
+	assert.NoError(t, err)
+
+	time.Sleep(1 * time.Second)
+	cancel()
+
+	mockHelper.AssertExpectations(t)
+	mockHandler.AssertExpectations(t)
+}