Skip to content

[chore] Fix Get Default Address on Newly Hydrated Wallet #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[chore] Fix Get Default Address on Newly Hydrated Wallet #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- Contract invocation support.

### Fixed

- Fixed bug in `Wallet` `default_address` property for newly hydrated wallets.

## [0.0.3] - 2024-09-25

### Added
Expand Down
2 changes: 1 addition & 1 deletion cdp/wallet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ def _address(self, address_id: str) -> WalletAddress | None:

"""
return next(
(address for address in self._addresses if address.address_id == address_id),
(address for address in self.addresses if address.address_id == address_id),
None,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/test_wallet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _create_wallet_model(
network_id="base-sepolia",
default_address=None,
feature_set=None,
server_signer_status="active_seed",
server_signer_status="active_seed"
):
if default_address is None:
default_address = address_model_factory()
Expand Down
Loading