Skip to content

[chore] Fix Get Default Address on Newly Hydrated Wallet #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2024
Merged

[chore] Fix Get Default Address on Newly Hydrated Wallet #14

merged 1 commit into from
Sep 30, 2024

Conversation

@John-peterson-coinbase
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase commented Sep 29, 2024

What changed? Why?

  • Fix bug that caused an exception to be raised when getting wallet.default_address directly after wallet.load_seed(...)

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Sep 29, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase force-pushed the chore-default-address-hydration branch from 6286af6 to bb3b249 Compare September 30, 2024 17:08
@John-peterson-coinbase John-peterson-coinbase merged commit cda596a into master Sep 30, 2024
7 checks passed
@cb-heimdall
Copy link

cb-heimdall commented Sep 30, 2024

Review Error for rohan-agarwal-coinbase @ 2024-09-30 17:11:06 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase