Skip to content

Conversation

@chrfla-cognite
Copy link

@chrfla-cognite chrfla-cognite requested a review from a team as a code owner July 28, 2025 17:39
@polomani
Copy link
Collaborator

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for agentsAcl by introducing the necessary types in packages/stable/src/types.ts. The changes are straightforward and follow the existing structure for ACL capabilities. I've identified a couple of opportunities to improve code consistency and maintainability by ensuring new types and properties are sorted alphabetically, which appears to be an implicit convention in this file. Please see the detailed comments.


export type AclScope3D = AclScopeAll;

export type AclScopeAgents = AclScopeAll;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For consistency and better maintainability, this new type should be placed alphabetically among the other AclScope... type definitions. The other AclScope... types are grouped together starting around line 141. This type should be placed before AclScopeAnalytics.

}

export type SingleCogniteCapability =
| { agentsAcl: AclAgents }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While agentsAcl is added here, the properties in the SingleCogniteCapability union type are not alphabetically sorted. This makes the type harder to read and maintain as it grows. Please consider sorting all properties in this union type alphabetically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants