chore: moving some constants from around the test suite into a constants file

Author: JohnAllenTech

e2e/articles.spec.ts

@@ -1,6 +1,6 @@
 import { test, expect } from "playwright/test";
 import { randomUUID } from "crypto";
-import { loggedInAsUserOne } from "./utils";
+import { articleContent, articleExcerpt, loggedInAsUserOne } from "./utils";
 
 test.describe("Unauthenticated Articles Page", () => {
   test("Should show popular tags", async ({ page, isMobile }) => {
@@ -18,7 +18,7 @@ test.describe("Unauthenticated Articles Page", () => {
     page,
   }) => {
     await page.goto("http://localhost:3000/articles/e2e-test-slug-published");
-    await expect(page.getByText("Lorem ipsum dolor sit amet,")).toBeVisible();
+    await expect(page.getByText(articleExcerpt)).toBeVisible();
     await expect(
       page.getByRole("heading", { name: "Published Article" }),
     ).toBeVisible();
@@ -223,8 +223,6 @@ test.describe("Authenticated Articles Page", () => {
   });
 
   test("Should write and publish an article", async ({ page, isMobile }) => {
-    const articleContent =
-      "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas vitae ipsum id metus vestibulum rutrum eget a diam. Integer eget vulputate risus, ac convallis nulla. Mauris sed augue nunc. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nam congue posuere tempor. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Ut ac augue non libero ullamcorper ornare. Ut commodo ligula vitae malesuada maximus. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Etiam sagittis justo non justo placerat, a dapibus sapien volutpat. Nullam ullamcorper sodales justo sed.";
     const articleTitle = "Lorem Ipsum";
     await page.goto("http://localhost:3000");
     // Waits for articles to be loaded
@@ -261,7 +259,7 @@ test.describe("Authenticated Articles Page", () => {
       /^http:\/\/localhost:3000\/articles\/lorem-ipsum-.*$/,
     );
 
-    await expect(page.getByText("Lorem ipsum dolor sit amet,")).toBeVisible();
+    await expect(page.getByText(articleExcerpt)).toBeVisible();
     await expect(
       page.getByRole("heading", { name: "Lorem Ipsum" }),
     ).toBeVisible();
@@ -296,7 +294,7 @@ test.describe("Authenticated Articles Page", () => {
       .locator("div")
       .filter({ hasText: /^Thanks for the positive feedback!$/ })
       .count();
-    await expect(page.getByText("Lorem ipsum dolor sit amet,")).toBeVisible();
+    await expect(page.getByText(articleExcerpt)).toBeVisible();
     await expect(
       page.getByRole("heading", { name: "Published Article" }),
     ).toBeVisible();

e2e/my-posts.spec.ts

@@ -1,5 +1,5 @@
 import test, { expect } from "@playwright/test";
-import { loggedInAsUserOne } from "./utils";
+import { articleExcerpt, loggedInAsUserOne } from "./utils";
 
 test.describe("Unauthenticated my-posts Page", () => {
   test("Unauthenticed users should be redirected to get-started page if they access my-posts directly", async ({
@@ -39,20 +39,18 @@ test.describe("Authenticated my-posts Page", () => {
     await expect(
       page.getByRole("heading", { name: "Draft Article" }),
     ).toBeVisible();
-    await expect(page.getByText("Lorem ipsum dolor sit amet")).toBeVisible();
+    await expect(page.getByText(articleExcerpt)).toBeVisible();
 
     await page.getByRole("link", { name: "Scheduled" }).click();
     await expect(
       page.getByRole("heading", { name: "Scheduled Article" }),
     ).toBeVisible();
-    await expect(page.getByText("Lorem ipsum dolor sit amet")).toBeVisible();
+    await expect(page.getByText(articleExcerpt)).toBeVisible();
 
     await page.getByRole("link", { name: "Published" }).click();
     await expect(
       page.getByRole("heading", { name: "Published Article" }),
     ).toBeVisible();
-    await expect(
-      page.getByText("Lorem ipsum dolor sit amet", { exact: true }),
-    ).toBeVisible();
+    await expect(page.getByText(articleExcerpt, { exact: true })).toBeVisible();
   });
 });

e2e/setup.ts

@@ -2,6 +2,7 @@ import dotenv from "dotenv";
 import postgres from "postgres";
 import { drizzle } from "drizzle-orm/postgres-js";
 import { post, comment } from "@/server/db/schema";
+import { articleContent, articleExcerpt } from "./utils";
 
 dotenv.config(); // Load .env file contents into process.env
 
@@ -23,8 +24,6 @@ export const setup = async () => {
     const scheduledPostId = "1nFnMmN2";
     const draftPostId = "1nFnMmN3";
     const now = new Date().toISOString();
-    const articleContent =
-      "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas vitae ipsum id metus vestibulum rutrum eget a diam. Integer eget vulputate risus, ac convallis nulla. Mauris sed augue nunc. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nam congue posuere tempor. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Ut ac augue non libero ullamcorper ornare. Ut commodo ligula vitae malesuada maximus. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Etiam sagittis justo non justo placerat, a dapibus sapien volutpat. Nullam ullamcorper sodales justo sed.";
 
     const oneYearFromToday = new Date(now);
     oneYearFromToday.setFullYear(oneYearFromToday.getFullYear() + 1);
@@ -35,7 +34,7 @@ export const setup = async () => {
         .values({
           id: publishedPostId,
           published: now,
-          excerpt: "Lorem ipsum dolor sit amet",
+          excerpt: articleExcerpt,
           updatedAt: now,
           slug: "e2e-test-slug-published",
           likes: 10,
@@ -52,7 +51,7 @@ export const setup = async () => {
         .values({
           id: scheduledPostId,
           published: null,
-          excerpt: "Lorem ipsum dolor sit amet",
+          excerpt: articleExcerpt,
           updatedAt: now,
           slug: "e2e-test-slug-draft",
           likes: 10,
@@ -69,7 +68,7 @@ export const setup = async () => {
         .values({
           id: draftPostId,
           published: oneYearFromToday.toISOString(),
-          excerpt: "Lorem ipsum dolor sit amet",
+          excerpt: articleExcerpt,
           updatedAt: now,
           slug: "e2e-test-slug-scheduled",
           likes: 10,

e2e/utils/constants.ts

@@ -0,0 +1,4 @@
+export const articleContent =
+  "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas vitae ipsum id metus vestibulum rutrum eget a diam. Integer eget vulputate risus, ac convallis nulla. Mauris sed augue nunc. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nam congue posuere tempor. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Ut ac augue non libero ullamcorper ornare. Ut commodo ligula vitae malesuada maximus. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Etiam sagittis justo non justo placerat, a dapibus sapien volutpat. Nullam ullamcorper sodales justo sed.";
+
+export const articleExcerpt = "Lorem ipsum dolor sit amet";

e2e/utils/index.ts

@@ -1 +1,2 @@
 export * from "./utils";
+export * from "./constants";