JUnit Jupiter best practices (#111)

Co-authored-by: Moderne <[email protected]>

Author: slachiewicz

src/test/java/org/codehaus/plexus/resource/ResourceManagerTest.java

@@ -49,7 +49,7 @@ class ResourceManagerTest {
     private ResourceManager resourceManager;
 
     @Test
-    void testResourceManagerRetrievingInputStreams() throws Exception {
+    void resourceManagerRetrievingInputStreams() throws Exception {
         InputStream in;
 
         File absoluteFile = new File(getBasedir(), "src/test/file-resources/dir/file.txt").getAbsoluteFile();
@@ -72,7 +72,7 @@ void testResourceManagerRetrievingInputStreams() throws Exception {
     }
 
     @Test
-    void testResourceManagerRetrievingFiles() throws Exception {
+    void resourceManagerRetrievingFiles() throws Exception {
         File f;
 
         File absoluteFile = new File(getBasedir(), "src/test/file-resources/dir/file.txt").getAbsoluteFile();
@@ -95,7 +95,7 @@ void testResourceManagerRetrievingFiles() throws Exception {
     }
 
     @Test
-    void testResourceManagerRetrievingFilesToSpecificLocation() throws Exception {
+    void resourceManagerRetrievingFilesToSpecificLocation() throws Exception {
         File outDir = new File(getBasedir(), "target/test/unit/output-directory");
 
         resourceManager.setOutputDirectory(outDir);

src/test/java/org/codehaus/plexus/resource/loader/FileResourceLoaderTest.java

@@ -39,24 +39,24 @@
 @PlexusTest
 class FileResourceLoaderTest extends AbstractResourceLoaderTest {
     @Test
-    void testLookupWithAAbsolutePathName() throws Exception {
+    void lookupWithAAbsolutePathName() throws Exception {
         assertResource("/dir/file.txt", "file.txt");
     }
 
     @Test
-    void testLookupWithARelativePath() throws Exception {
+    void lookupWithARelativePath() throws Exception {
         assertResource("dir/file.txt", "file.txt");
     }
 
     @Test
-    void testLookupWhenTheResourceIsMissing() throws Exception {
+    void lookupWhenTheResourceIsMissing() throws Exception {
         assertMissingResource("/foo.txt");
 
         assertMissingResource("foo.txt");
     }
 
     @Test
-    void testPlexusResource() throws Exception {
+    void plexusResource() throws Exception {
         PlexusResource resource = resourceLoader.getResource("/dir/file.txt");
         final File f = new File("src/test/file-resources", "/dir/file.txt");
         assertEquals(f.getAbsolutePath(), resource.getFile().getPath());

src/test/java/org/codehaus/plexus/resource/loader/ThreadContextClasspathResourceLoaderTest.java

@@ -41,24 +41,24 @@
 @PlexusTest
 class ThreadContextClasspathResourceLoaderTest extends AbstractResourceLoaderTest {
     @Test
-    void testLookupWithAAbsolutePathName() throws Exception {
+    void lookupWithAAbsolutePathName() throws Exception {
         assertResource("/dir/classpath.txt", "classpath.txt");
     }
 
     @Test
-    void testLookupWithARelativePath() throws Exception {
+    void lookupWithARelativePath() throws Exception {
         assertResource("dir/classpath.txt", "classpath.txt");
     }
 
     @Test
-    void testLookupWhenTheResourceIsMissing() throws Exception {
+    void lookupWhenTheResourceIsMissing() throws Exception {
         assertMissingResource("/foo.txt");
 
         assertMissingResource("foo.txt");
     }
 
     @Test
-    void testLookupWithANullThreadContextClassLoader() throws Exception {
+    void lookupWithANullThreadContextClassLoader() throws Exception {
         ClassLoader loader = Thread.currentThread().getContextClassLoader();
 
         Thread.currentThread().setContextClassLoader(null);
@@ -71,7 +71,7 @@ void testLookupWithANullThreadContextClassLoader() throws Exception {
     }
 
     @Test
-    void testPlexusResource() throws Exception {
+    void plexusResource() throws Exception {
         PlexusResource resource = resourceLoader.getResource("/dir/classpath.txt");
         assertNull(resource.getFile());
         assertNull(resource.getURI());

src/test/java/org/codehaus/plexus/resource/loader/URLResourceLoaderTest.java

@@ -21,7 +21,7 @@ class URLResourceLoaderTest {
     private ResourceLoader resourceLoader = new URLResourceLoader();
 
     @Test
-    void testMalformedURL() {
+    void malformedURL() {
         try {
             resourceLoader.getResource("LICENSE.txt");
             fail();

src/test/java/org/codehaus/plexus/resource/loader/manager/ResourceManagerTest.java

@@ -42,7 +42,7 @@ class ResourceManagerTest {
     private ResourceManager resourceManager;
 
     @Test
-    void testFoo() {
+    void foo() {
         assertNotNull(resourceManager);
     }
 }