Skip to content

Commit 3093b97

Browse files
committed
envconfig: default GRPC_ENFORCE_ALPN_ENABLED to false
CRDB at v1.68.0 fails to communicate with CRDB at v1.56.3 due to this check. This is strange, since CRDB uses gRPC throughout, and in both v1.56.3 and v1.68.0 uses `tls.NewConfig` which ensures that `NextProtos` always contains `h2`. gRPC introduced this check in grpc#7535. See: cockroachdb/cockroach#136278 (comment)
1 parent 766c020 commit 3093b97

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/envconfig/envconfig.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ var (
4545
// option is present for backward compatibility. This option may be overridden
4646
// by setting the environment variable "GRPC_ENFORCE_ALPN_ENABLED" to "true"
4747
// or "false".
48-
EnforceALPNEnabled = boolFromEnv("GRPC_ENFORCE_ALPN_ENABLED", true)
48+
EnforceALPNEnabled = boolFromEnv("GRPC_ENFORCE_ALPN_ENABLED", false)
4949
// XDSFallbackSupport is the env variable that controls whether support for
5050
// xDS fallback is turned on. If this is unset or is false, only the first
5151
// xDS server in the list of server configs will be used.

0 commit comments

Comments
 (0)