.coafile: Add NoFutureImportBear

Closes #267

Author: ankitxjoshi

.coafile

@@ -42,3 +42,6 @@ shortlog_regex = ([^:]*|[^:]+[^ ]: [A-Z0-9*].*)
 [all.yml]
 bears = YAMLLintBear
 files = *.yml, .ci/*.yml, tests/**/*.yml
+
+[all.nofutureimports]
+bears = NoFutureImportBear

.moban.yaml

@@ -34,6 +34,7 @@ dependencies:
   - coala_utils~=0.6.6
   - gemfileparser~=0.6.2
   - pyjsparser~=2.4.5
+  - git+https://gitlab.com/MacBox7/coala-pyflakes.git#egg=coala-pyflakes
 
 
 configuration:

requirements.txt

@@ -3,3 +3,4 @@ coala_bears~=0.12.0.dev20170722110839
 coala_utils~=0.6.6
 gemfileparser~=0.6.2
 pyjsparser~=2.4.5
+git+https://gitlab.com/MacBox7/coala-pyflakes.git#egg=coala-pyflakes

setup.py

@@ -59,6 +59,220 @@ def run_tests(self):
 __dir__ = os.path.dirname(__file__)
 
 
+from distutils.version import LooseVersion  # noqa (late-import)
+
+
+class PEP440Version(LooseVersion):
+    """
+    Basic PEP440 version with a few features.
+
+    Uses the same version semantics as LooseVersion,
+    with the addition that a ``v`` prefix is allowed
+    in the version as required by PEP 440.
+
+    vstring may be a list, tuple or string.
+
+    v_prefix indicates whether output of the version
+    should include a v prefix.
+
+    v_prefix is auto-detected by default.
+    Set to False to remove if present, or True to add if missing.
+    """
+
+    def __init__(self, vstring=None, v_prefix=None):
+        self._v_prefix = v_prefix
+
+        if isinstance(vstring, (list, tuple)):
+            type_ = type(vstring)
+            vstring = '.'.join(str(i) for i in vstring)
+        else:
+            type_ = list
+
+        vstring = vstring.strip()
+
+        if vstring.startswith('v'):
+            vstring = vstring[1:]
+            if vstring.startswith('!'):
+                raise ValueError('Invalid use of epoch')
+            if v_prefix is not False:
+                self._v_prefix = True
+
+        # Can not use super(..) on Python 2.7
+        LooseVersion.__init__(self, vstring)
+        if self._v_prefix:
+            self.vstring = 'v' + self.vstring
+        if len(self.version) > 1 and self.version[1] == '!':
+            self._epoch = self.version[0]
+            if not isinstance(self._epoch, int) or len(self.version) < 3:
+                raise ValueError('Invalid use of epoch')
+
+        # Normalise to lower case
+        self.version = [
+            x if isinstance(x, int) else x.lower() for x in self.version
+            if x not in ('-', '_')]
+
+        if self.version[-1] != '*' and not isinstance(self.version[-1], int):
+            self.version += (0, )
+
+        if type_ is tuple:
+            self.version = tuple(self.version)
+
+        self._final = None
+        self._previous = None
+
+    def __repr__(self):
+        return "%s('%s')" % (self.__class__.__name__, str(self))
+
+    @property
+    def is_dev(self):
+        return any(part == 'dev' for part in self.version)
+
+    @property
+    def has_epoch(self):
+        return any(part == '!' for part in self.version)
+
+    @property
+    def final(self):
+        """
+        Provide only the final component of the version.
+
+        A new instance is return if this instance is not final.
+        """
+        if self.has_epoch:
+            raise NotImplementedError
+
+        if self._final is not None:
+            return self._final
+
+        for i, part in enumerate(self.version):
+            if not isinstance(part, int):
+                final = self.version[:i]
+                break
+        else:
+            self._final = self
+            return self
+
+        self._final = PEP440Version(final, self._v_prefix)
+
+        return self._final
+
+    @property
+    def is_final(self):
+        return self.final == self
+
+    @property
+    def is_zero(self):
+        return all(part == 0 for part in self.version)
+
+    _zero_message = 'version prior to 0.0 can not exist'
+
+    def _estimate_previous(self):
+        """
+        Return a new version calculated to be the previous version.
+
+        Currently only handles when the current instance is a final version.
+
+        To really get the previous for 1.0.0, we need to consult PyPi,
+        git tags, or some other source of all released versions,
+        to find the highest patch release in the prior minor release, or
+        highest minor releases if there were no patch releases in the
+        last minor release, etc.
+
+        As a result, currently this assumes that release x.(x-1).0 exists
+        in that instance.
+        """
+        if self._previous:
+            return self._previous
+
+        assert self.is_final, '%r is not final' % self
+
+        if self.is_zero:
+            raise ValueError(self._zero_message)
+
+        previous = self._decrement(self.version)
+        self._previous = PEP440Version(previous, self._v_prefix)
+        return self._previous
+
+    @staticmethod
+    def _decrement(version):
+        pos = len(version) - 1
+
+        # Look for non-zero int part
+        while pos != 0 and not (isinstance(version[pos], int) and version[pos]):
+            pos -= 1
+
+        previous = []
+        if pos:
+            previous = version[:pos]
+
+        previous += (version[pos] - 1, )
+
+        if len(previous) == len(version):
+            return previous
+
+        remaining = version[pos + 1:-1]
+
+        previous += tuple(
+            0 if isinstance(i, int) else i for i in remaining)
+
+        previous += ('*', )
+
+        return previous
+
+
+def egg_name_to_requirement(name):
+    name = name.strip()
+    parts = name.split('-')
+
+    # The first part may be v or v0, which would be considered a version
+    # if processed in the following loop.
+    name_parts = [parts[0]]
+    # Pre-releases may contain a '-' and be alpha only, so we must
+    # parse from the second part to find the first version-like part.
+    for part in parts[1:]:
+        version = PEP440Version(part)
+        if isinstance(version.version[0], int):
+            break
+        name_parts.append(part)
+
+    version_parts = parts[len(name_parts):]
+
+    if not version_parts:
+        return name
+
+    name = '-'.join(name_parts)
+
+    version = PEP440Version('-'.join(version_parts))
+
+    # Assume that alpha, beta, pre, post & final releases
+    # are in PyPi so setuptools can find it.
+    if not version.is_dev:
+        return name + '==' + str(version)
+
+    # setuptools fails if a version is given with any specifier such as
+    # `==`, `=~`, `>`, if the version is not in PyPi.
+
+    # For development releases, which will not usually be PyPi,
+    # setuptools will typically fail.
+
+    # So we estimate a previous release that should exist in PyPi,
+    # by decrementing the lowest final version part, and use version
+    # specifier `>` so that the installed package from VCS will have a
+    # version acceptable to the requirement.
+
+    # With major and minor releases, the previous version must be guessed.
+    # If the version was `2.1.0`, the previous_version will be literally
+    # `2.0.*` as it assumes that a prior minor release occurred and used
+    # the same versioning convention.
+    previous_version = version.final._estimate_previous()
+
+    if previous_version.is_zero:
+        raise ValueError(
+            'Version %s could not be decremented' % version)
+
+    return name + '>' + str(previous_version)
+
+
 def read_requirements(filename):
     """
     Parse a requirements file.
@@ -84,7 +298,7 @@ def read_requirements(filename):
 
                 DEPENDENCY_LINKS.append(line)
 
-                line = egg_name.replace('-', '==')
+                line = egg_name_to_requirement(egg_name)
 
             data.append(line)
 

test-requirements.txt

@@ -17,5 +17,5 @@ pytest-timeout~=1.3.0
 pytest-travis-fold~=1.3.0
 pytest-xdist~=1.15
 requests-mock~=1.2
-pip!=9.0.2, !=10.0.*
+pip!=9.0.2, !=10.0.*, !=18.0
 wheel~=0.29