diff --git a/.travis.yml b/.travis.yml index 2b01760..6ee4129 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,8 +15,6 @@ jobs: - php: 7.2 - php: 7.3 - php: 7.4 - - php: hhvm-3.18 - install: composer require phpunit/phpunit:^5 --dev - name: "Windows" os: windows language: shell # no built-in php support @@ -27,7 +25,6 @@ jobs: - php -r "file_put_contents(php_ini_loaded_file(),'extension_dir=ext'.PHP_EOL,FILE_APPEND);" - php -r "file_put_contents(php_ini_loaded_file(),'extension=sockets'.PHP_EOL,FILE_APPEND);" allow_failures: - - php: hhvm-3.18 - os: windows install: diff --git a/README.md b/README.md index 9b38974..c2e30e3 100644 --- a/README.md +++ b/README.md @@ -202,7 +202,7 @@ See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades. This project aims to run on any platform and thus does not require any PHP extensions besides `ext-sockets` and supports running on legacy PHP 5.3 through -current PHP 7+ and HHVM. +current PHP 7+. It's *highly recommended to use PHP 7+* for this project. ## Tests diff --git a/tests/SocketTest.php b/tests/SocketTest.php index 8ce0976..ca73603 100644 --- a/tests/SocketTest.php +++ b/tests/SocketTest.php @@ -224,8 +224,7 @@ public function testServerNonBlockingAcceptNobody(Socket $server) $server->accept(); $this->fail('accept() MUST throw an exception'); } catch (Exception $e) { - // code should usually be SOCKET_EAGAIN, hhvm uses SOCKET_EBADF, so let's play it safe - $this->assertNotEquals(0, $e->getCode()); + $this->assertEquals(SOCKET_EWOULDBLOCK, $e->getCode()); } }