Merge pull request #67 from clue-labs/tests

Fix online tests and add option to exclude tests against httpbin.org

Author: clue

README.md

@@ -54,6 +54,7 @@ mess with most of the low-level details.
   * [UNIX domain sockets](#unix-domain-sockets)
   * [Options](#options)
 * [Install](#install)
+* [Tests](#tests)
 * [License](#license)
 
 ## Quickstart example
@@ -555,6 +556,30 @@ $ composer require clue/buzz-react:^1.1
 
 See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.
 
+## Tests
+
+To run the test suite, you first need to clone this repo and then install all
+dependencies [through Composer](https://getcomposer.org):
+
+```bash
+$ composer install
+```
+
+To run the test suite, go to the project root and run:
+
+```bash
+$ php vendor/bin/phpunit
+```
+
+The test suite also contains a number of functional integration tests that send
+test HTTP requests against the online service http://httpbin.org and thus rely
+on a stable internet connection.
+If you do not want to run these, they can simply be skipped like this:
+
+```bash
+$ php vendor/bin/phpunit --exclude-group online
+```
+
 ## License
 
 MIT

composer.json

@@ -26,6 +26,9 @@
     },
     "require-dev": {
         "clue/block-react": "^1.0",
-        "phpunit/phpunit": "^4.5"
+        "phpunit/phpunit": "^4.5",
+        "react/http": "^0.7.2",
+        "react/promise-stream": "^0.1.1",
+        "react/socket": "^0.8"
     }
 }

tests/FunctionalBrowserTest.php

@@ -10,6 +10,9 @@
 use Clue\React\Buzz\Message\ResponseException;
 use Clue\React\Block;
 use React\Stream\ReadableStream;
+use Psr\Http\Message\ServerRequestInterface;
+use React\Http\Response;
+use React\Promise\Stream;
 
 class FunctionalBrowserTest extends TestCase
 {
@@ -25,28 +28,33 @@ public function setUp()
         $this->browser = new Browser($this->loop);
     }
 
+    /** @group online */
     public function testSimpleRequest()
     {
         Block\await($this->browser->get($this->base . 'get'), $this->loop);
     }
 
+    /** @group online */
     public function testRedirectRequestRelative()
     {
         Block\await($this->browser->get($this->base . 'redirect-to?url=get'), $this->loop);
     }
 
+    /** @group online */
     public function testRedirectRequestAbsolute()
     {
         Block\await($this->browser->get($this->base . 'redirect-to?url=' . urlencode($this->base . 'get')), $this->loop);
     }
 
+    /** @group online */
     public function testNotFollowingRedirectsResolvesWithRedirectResult()
     {
         $browser = $this->browser->withOptions(array('followRedirects' => false));
 
         Block\await($browser->get($this->base . 'redirect/3'), $this->loop);
     }
 
+    /** @group online */
     public function testRejectingRedirectsRejects()
     {
         $browser = $this->browser->withOptions(array('maxRedirects' => 0));
@@ -55,6 +63,7 @@ public function testRejectingRedirectsRejects()
         Block\await($browser->get($this->base . 'redirect/3'), $this->loop);
     }
 
+    /** @group online */
     public function testCanAccessHttps()
     {
         if (!function_exists('stream_socket_enable_crypto')) {
@@ -64,6 +73,7 @@ public function testCanAccessHttps()
         Block\await($this->browser->get('https://www.google.com/'), $this->loop);
     }
 
+    /** @group online */
     public function testVerifyPeerEnabledForBadSslRejects()
     {
         if (!function_exists('stream_socket_enable_crypto')) {
@@ -89,6 +99,7 @@ public function testVerifyPeerEnabledForBadSslRejects()
         Block\await($browser->get('https://self-signed.badssl.com/'), $this->loop);
     }
 
+    /** @group online */
     public function testVerifyPeerDisabledForBadSslResolves()
     {
         if (!function_exists('stream_socket_enable_crypto')) {
@@ -113,12 +124,14 @@ public function testVerifyPeerDisabledForBadSslResolves()
         Block\await($browser->get('https://self-signed.badssl.com/'), $this->loop);
     }
 
+    /** @group online */
     public function testInvalidPort()
     {
         $this->setExpectedException('RuntimeException');
         Block\await($this->browser->get('http://www.google.com:443/'), $this->loop);
     }
 
+    /** @group online */
     public function testErrorStatusCodeRejectsWithResponseException()
     {
         try {
@@ -132,6 +145,7 @@ public function testErrorStatusCodeRejectsWithResponseException()
         }
     }
 
+    /** @group online */
     public function testPostString()
     {
         $response = Block\await($this->browser->post($this->base . 'post', array(), 'hello world'), $this->loop);
@@ -142,6 +156,28 @@ public function testPostString()
 
     public function testPostStreamChunked()
     {
+        // httpbin used to support `Transfer-Encoding: chunked` for requests,
+        // but not rejects those, so let's start our own server instance
+        $that = $this;
+        $server = new \React\Http\Server(function (ServerRequestInterface $request) use ($that) {
+            $that->assertFalse($request->hasHeader('Content-Length'));
+            $that->assertNull($request->getBody()->getSize());
+
+            return Stream\buffer($request->getBody())->then(function ($body) {
+                return new Response(
+                    200,
+                    array(),
+                    json_encode(array(
+                        'data' => $body
+                    ))
+                );
+            });
+        });
+        $socket = new \React\Socket\Server(0, $this->loop);
+        $server->listen($socket);
+
+        $this->base = str_replace('tcp:', 'http:', $socket->getAddress()) . '/';
+
         $stream = new ReadableStream();
 
         $this->loop->addTimer(0.001, function () use ($stream) {
@@ -153,8 +189,11 @@ public function testPostStreamChunked()
         $data = json_decode((string)$response->getBody(), true);
 
         $this->assertEquals('hello world', $data['data']);
+
+        $socket->close();
     }
 
+    /** @group online */
     public function testPostStreamKnownLength()
     {
         $stream = new ReadableStream();
@@ -170,6 +209,7 @@ public function testPostStreamKnownLength()
         $this->assertEquals('hello world', $data['data']);
     }
 
+    /** @group online */
     public function testPostStreamClosed()
     {
         $stream = new ReadableStream();