Skip to content

Commit 49e2b6a

Browse files
committed
Add a note about unable to self-sign
And remove some trailing whitespace from a line in sign_certd
1 parent ba3b60d commit 49e2b6a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

README.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ parameters of the certificate before deciding whether or not to actually
2828
sign the cert request. The signed certificate is again POSTed back to
2929
the server where the signature is validated.
3030

31+
Note that a requester may not sign their own request. If a +1 is
32+
received for a request by the same key as the one in the request then
33+
the signing request is rejected.
34+
3135
Once enough valid signatures are received the cert request is
3236
automatically signed using the signing key for the cert authority and
3337
made available for download by the requester using the request id.

sign_certd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ func (h *certRequestHandler) signOrRejectRequest(rw http.ResponseWriter, req *ht
596596
// Make sure the key attempting to sign the request is not the same as the key in the CSR
597597
if signerFp == requesterFp {
598598
err = errors.New("Signed by the same key as key in request")
599-
http.Error(rw, fmt.Sprintf("%v", err), http.StatusBadRequest)
599+
http.Error(rw, fmt.Sprintf("%v", err), http.StatusBadRequest)
600600
return
601601
}
602602

0 commit comments

Comments
 (0)