renaming of variables

Author: pierreglaser

tests/cloudpickle_test.py

@@ -964,7 +964,7 @@ def func_that_relies_on_dynamic_module(v=None):
             # x's value in the second function, it will be overriden by the
             # initial value of x in the child environment
 
-            with open('first_function.pk', 'wb') as fid:
+            with open('function_with_initial_globals.pk', 'wb') as fid:
                 cloudpickle.dump(mod.func_that_relies_on_dynamic_module, fid)
 
             # change the mod's global variable x
@@ -979,37 +979,38 @@ def func_that_relies_on_dynamic_module(v=None):
             child_process_code = """
                 import pickle
 
-                with open('first_function.pk','rb') as fid:
-                    first_f = pickle.load(fid)
+                with open('function_with_initial_globals.pk','rb') as fid:
+                    function_with_initial_globals = pickle.load(fid)
 
                 # at this point, a module called 'mod' should exist in
                 # _dynamic_modules_globals. further function loading
                 # will use the globals living in mod
 
-                assert first_f() == 1
+                assert function_with_initial_globals() == 1
 
                 # load a function with initial global variable x set to 2
                 with open('function_with_modified_globals.pk','rb') as fid:
-                    new_f = pickle.load(fid)
+                    function_with_modified_globals = pickle.load(fid)
 
                 # assert the initial global got overridden by
                 # _dynamic_modules_globals
-                assert new_f()==1
+                assert function_with_modified_globals()==1
 
                 # both function's global x should point to the
-                # same variable. calling first_f('test_value')
-                # will change this variable, and new_f() should
-                # return the changed variable
-                assert first_f('test_value') == 'test_value'
-                assert new_f() == 'test_value'
+                # same variable.
+                # calling function_with_initial_globals('test_value')
+                # will change this variable: function_with_modified_globals()
+                # should return the changed variable
+                assert function_with_initial_globals('test_value') == 'test_value'
+                assert function_with_modified_globals() == 'test_value'
             """
 
             # finally, we execute the code
             assert_run_python_script(textwrap.dedent(child_process_code))
 
         finally:
             # remove the created files
-            os.unlink('first_function.pk')
+            os.unlink('function_with_initial_globals.pk')
             os.unlink('function_with_modified_globals.pk')
 
     @pytest.mark.skipif(sys.version_info >= (3, 0),