Skip to content

Prevent infinite console.log()/console.info() loops with Wrangler E2E tests #8163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Prevent infinite console.log()/console.info() loops with Wrangler E2E tests #8163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
645ee63
Prevent infinite console.log/console.info loops with Vitest v3
penalosa Feb 17, 2025
7129311
Fix ESLint
penalosa Feb 17, 2025
be9595b
Rearrange remote/local
penalosa Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions packages/wrangler/e2e/startWorker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,18 +201,16 @@ describe.each(OPTIONS)("DevEnv (remote: $remote)", ({ remote }) => {
// through a worker (InspectorProxyWorker) which hits the limit (without the fix, compatibilityFlags:["increase_websocket_message_size"])
// By logging a large string we can verify that the inspector messages are being proxied successfully.
it("InspectorProxyWorker can proxy messages > 1MB", async (t) => {
t.onTestFinished(() => worker?.dispose());

const originalConsoleLog = console.log;
const mockConsoleLogImpl = (message: unknown, ...args: unknown[]) => {
if (typeof message === "string" && /z+/.test(message)) {
return; // don't log chunks of the large string
}

originalConsoleLog(message, ...args);
};
vi.spyOn(console, "info").mockImplementation(mockConsoleLogImpl);
vi.spyOn(console, "log").mockImplementation(mockConsoleLogImpl);
const consoleInfoSpy = vi
.spyOn(console, "info")
.mockImplementation(() => {});
const consoleLogSpy = vi.spyOn(console, "log").mockImplementation(() => {});

t.onTestFinished(() => {
consoleInfoSpy.mockRestore();
consoleLogSpy.mockRestore();
return worker?.dispose();
});

const LARGE_STRING = "This is a large string" + "z".repeat(2 ** 20);

Expand Down Expand Up @@ -250,9 +248,7 @@ describe.each(OPTIONS)("DevEnv (remote: $remote)", ({ remote }) => {
expect(consoleApiMessages).toContainMatchingObject({
method: "Runtime.consoleAPICalled",
params: expect.objectContaining({
args: [
{ type: "string", value: expect.stringContaining("zzzzzzzzz") },
],
args: [{ type: "string", value: LARGE_STRING }],
}),
});
},
Expand Down
Loading