[wrangler] Fix rendering of nested objects in R2 SQL query results#12506
Merged
petebacondarwin merged 7 commits intocloudflare:mainfrom Feb 10, 2026
Merged
[wrangler] Fix rendering of nested objects in R2 SQL query results#12506petebacondarwin merged 7 commits intocloudflare:mainfrom
petebacondarwin merged 7 commits intocloudflare:mainfrom
Conversation
Row values containing objects or arrays (e.g. from approx_top_k) were rendered as "[object Object]" because String() was called directly on non-primitive values. Use JSON.stringify for object types so nested structures are displayed as readable JSON in the table output.
🦋 Changeset detectedLatest commit: 5d41218 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
requested changes
Feb 10, 2026
- Replace individual toContain assertions with toMatchInlineSnapshot() so the full table output is captured (snapshot will be auto-populated on first CI run) - Add JSON.stringify replacer to convert null values inside nested objects to empty strings, consistent with top-level null handling - Add a null value in the test fixture to cover this case
Use the actual API response shape including the descriptor-based schema and real approx_top_k result values (0:961, 1:485, 2:364).
Empty toMatchInlineSnapshot() does not auto-populate in CI. Use toContain checks that validate the full JSON-stringified output, consistent with the existing successful query test in this file.
petebacondarwin
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
wrangler r2 sql queryrendering nested objects/arrays as[object Object]in table output.SQL functions like
approx_top_kreturn arrays of objects. TheformatSqlResultsfunction was callingString()on all cell values, which produces[object Object]for non-primitives. Now usesJSON.stringifyfor object types so they display as readable JSON.