Skip to content

Commit e3beb2e

Browse files
Remove temporary block on Worker/Pages deployment changesets (#12791)
1 parent 82cc2a8 commit e3beb2e

File tree

2 files changed

+0
-29
lines changed

2 files changed

+0
-29
lines changed

tools/deployments/__tests__/validate-changesets.test.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ describe("validateChangesets()", () => {
9494
["package-a", { name: "package-a" }],
9595
["package-b", { name: "package-b" }],
9696
["package-c", { name: "package-c" }],
97-
["package-d", { name: "package-d", "workers-sdk": { deploy: true } }],
9897
]),
9998
[
10099
{
@@ -152,23 +151,13 @@ describe("validateChangesets()", () => {
152151
153152
docs: test`,
154153
},
155-
{
156-
file: "deployable-package.md",
157-
contents: dedent`
158-
---
159-
"package-d": patch
160-
---
161-
162-
fix: test`,
163-
},
164154
]
165155
);
166156
expect(errors).toMatchInlineSnapshot(`
167157
[
168158
"Error: could not parse changeset - invalid frontmatter: at file "invalid-frontmatter.md"",
169159
"Unknown package name "package-invalid" in changeset at "invalid-package.md".",
170160
"Invalid type "foo" for package "package-a" in changeset at "invalid-type.md".",
171-
"Currently we are not allowing changes to package "package-d" in changeset at "deployable-package.md" since it would trigger a Worker/Pages deployment.",
172161
]
173162
`);
174163
});

tools/deployments/validate-changesets.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -30,24 +30,6 @@ export function validateChangesets(
3030
);
3131
}
3232

33-
// TEMPORARILY BLOCK PACKAGES THAT WOULD DEPLOY WORKERS
34-
const ALLOWED_PRIVATE_PACKAGES = [
35-
"@cloudflare/workers-shared",
36-
"@cloudflare/quick-edit",
37-
"@cloudflare/devprod-status-bot",
38-
"@cloudflare/workers-playground",
39-
];
40-
if (
41-
packages.get(release.name)?.["workers-sdk"]?.deploy &&
42-
// Exception: deployments for these workers are allowed now
43-
!ALLOWED_PRIVATE_PACKAGES.includes(release.name)
44-
) {
45-
errors.push(
46-
`Currently we are not allowing changes to package "${release.name}" in changeset at "${file}" since it would trigger a Worker/Pages deployment.`
47-
);
48-
}
49-
// END TEMPORARILY BLOCK PACKAGES THAT WOULD DEPLOY WORKERS
50-
5133
if (release.type === "major") {
5234
errors.push(
5335
`Major version bumps are not allowed for package "${release.name}" in changeset at "${file}".`

0 commit comments

Comments
 (0)