add more tests around custom sockets

Author: anonrig

src/node/internal/internal_net.ts

@@ -1201,6 +1201,10 @@ async function startRead(socket: Socket): Promise<void> {
         break;
       }
     }
+  } catch (err) {
+    // Ignore error, and don't log them.
+    // This is mostly triggered for invalid sockets with following errors:
+    // - "This ReadableStream belongs to an object that is closing."
   } finally {
     // Disable eslint to match Node.js behavior
     // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition

src/workerd/api/node/tests/tls-nodejs-tcp-server.js

@@ -72,3 +72,9 @@ const echoServer = tls.createServer(options, (s) => {
   s.pipe(s);
 });
 echoServer.listen(8888, () => console.info('Listening on port 8888'));
+
+// Taken from test-tls-connect-given-socket.js
+const helloServer = tls.createServer(options, (socket) => {
+  socket.end('Hello');
+});
+helloServer.listen(8887, () => console.info('Listening on port 8887'));

src/workerd/api/node/tests/tls-nodejs-test.js

@@ -23,8 +23,9 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 import tls from 'node:tls';
-import { strictEqual, ok, rejects } from 'node:assert';
+import { strictEqual, ok, rejects, throws } from 'node:assert';
 import { once } from 'node:events';
+import net from 'node:net';
 
 // Tests are taken from
 // https://github.com/nodejs/node/blob/304743655d5236c2edc39094336ee2667600b684/test/parallel/test-tls-connect-abort-controller.js
@@ -209,3 +210,75 @@ export const tlsConnectNoHost = {
     await promise;
   },
 };
+
+// Tests are taken from
+// https://github.com/nodejs/node/blob/755e4603fd1679de72d250514ea5096b272ae8d6/test/parallel/test-tls-connect-given-socket.js
+export const tlsConnectGivenSocket = {
+  async test() {
+    const promises = [];
+    let waiting = 2;
+    function establish(socket, shouldNotCallCallback = false) {
+      const { promise, resolve } = Promise.withResolvers();
+      promises.push(promise);
+      const client = tls.connect(
+        {
+          socket: socket,
+        },
+        () => {
+          if (shouldNotCallCallback) {
+            reject(new Error('should not have called tls.connect() callback'));
+            return;
+          }
+          let data = '';
+          client
+            .on('data', (chunk) => {
+              data += chunk.toString();
+            })
+            .on('end', () => {
+              strictEqual(data, 'Hello');
+              if (--waiting === 0) {
+                resolve();
+              }
+            });
+        }
+      );
+
+      if (shouldNotCallCallback) {
+        queueMicrotask(() => resolve());
+      }
+
+      return client;
+    }
+
+    const port = 8887;
+    // Immediate death socket
+    const immediateDeath = net.connect(port);
+    establish(immediateDeath, true).destroy();
+
+    // Outliving
+    const outlivingTCPPromise = Promise.withResolvers();
+    const outlivingTCP = net.connect(port, () => {
+      outlivingTLS.destroy();
+      next();
+      outlivingTCPPromise.resolve();
+    });
+    promises.push(outlivingTCPPromise.promise);
+    const outlivingTLS = establish(outlivingTCP, true);
+
+    function next() {
+      // Already connected socket
+      const { promise, resolve } = Promise.withResolvers();
+      const connected = net.connect(port, () => {
+        establish(connected);
+        resolve();
+      });
+      promises.push(promise);
+
+      // Connecting socket
+      const connecting = net.connect(port);
+      establish(connecting);
+    }
+
+    await Promise.all(promises);
+  },
+};