Fix memory leak in PartitionedAggNode

skye · Nong Li · commit ebbaf5fc3cf6 · 2014-10-09T22:51:18.000-07:00
Change-Id: Ifedffde3d67102bf8e4ab5a46d68812f49341bdb Reviewed-on: http://gerrit.sjc.cloudera.com:8080/4809 Reviewed-by: Nong Li <nong@cloudera.com> Tested-by: jenkins
diff --git a/be/src/exec/partitioned-aggregation-node.cc b/be/src/exec/partitioned-aggregation-node.cc
@@ -410,6 +410,7 @@ Status PartitionedAggregationNode::Partition::InitStreams() {
   agg_fn_pool.reset(new MemPool(parent->state_->udf_mem_tracker()));
   for (int i = 0; i < parent->agg_fn_ctxs_.size(); ++i) {
     agg_fn_ctxs.push_back(parent->agg_fn_ctxs_[i]->impl()->Clone(agg_fn_pool.get()));
+    parent->state_->obj_pool()->Add(agg_fn_ctxs[i]);
   }
 
   aggregated_row_stream.reset(new BufferedTupleStream(parent->state_,

Original file line number	Diff line number	Diff line change
`@@ -410,6 +410,7 @@ Status PartitionedAggregationNode::Partition::InitStreams() {`
`410`	`410`	`agg_fn_pool.reset(new MemPool(parent->state_->udf_mem_tracker()));`
`411`	`411`	`for (int i = 0; i < parent->agg_fn_ctxs_.size(); ++i) {`
`412`	`412`	`agg_fn_ctxs.push_back(parent->agg_fn_ctxs_[i]->impl()->Clone(agg_fn_pool.get()));`
	`413`	`+ parent->state_->obj_pool()->Add(agg_fn_ctxs[i]);`
`413`	`414`	`}`
`414`	`415`
`415`	`416`	`aggregated_row_stream.reset(new BufferedTupleStream(parent->state_,`