cleaned up tests - using //nolint:errcheck

Author: jeremycook123

pkg/rocket/rocket_test.go

@@ -20,7 +20,8 @@ func TestIgniteRocket(t *testing.T) {
 	rocket := NewRocket("Saturn-V", "Nasa", 5, 25000)
 	rocket.AddFuel(100)
 
-	_ = rocket.Ignite()
+	//nolint:errcheck
+	rocket.Ignite()
 	got := rocket.Engines.Ignited
 	want := true
 
@@ -49,14 +50,16 @@ func TestThrottleUpEnginesNotIgnited(t *testing.T) {
 	}
 }
 
+//nolint:errcheck
 func TestThrottleUp(t *testing.T) {
 	rocket := NewRocket("Saturn-V", "Nasa", 5, 25000)
 	rocket.AddFuel(100)
 
-	_ = rocket.Ignite()
+	rocket.Ignite()
+
+	rocket.ThrottleUp(100)
+	rocket.ThrottleUp(100)
 
-	_, _ = rocket.ThrottleUp(100)
-	_, _ = rocket.ThrottleUp(100)
 	got, _ := rocket.ThrottleUp(100)
 	want := 300
 
@@ -65,13 +68,14 @@ func TestThrottleUp(t *testing.T) {
 	}
 }
 
+//nolint:errcheck
 func TestThrottleUpExceedMaxSpped(t *testing.T) {
 	rocket := NewRocket("Saturn-V", "Nasa", 5, 25000)
 	rocket.AddFuel(100)
 
-	_ = rocket.Ignite()
+	rocket.Ignite()
 
-	_, _ = rocket.ThrottleUp(25000)
+	rocket.ThrottleUp(25000)
 	_, err := rocket.ThrottleUp(100)
 
 	if err == nil {
@@ -90,16 +94,17 @@ func TestThrottleDownEnginesNotIgnited(t *testing.T) {
 	}
 }
 
+//nolint:errcheck
 func TestThrottleDown(t *testing.T) {
 	rocket := NewRocket("Saturn-V", "Nasa", 5, 25000)
 	rocket.AddFuel(100)
 
-	_ = rocket.Ignite()
+	rocket.Ignite()
 
-	_, _ = rocket.ThrottleUp(1000)
-	_, _ = rocket.ThrottleUp(100)
-	_, _ = rocket.ThrottleUp(100)
-	_, _ = rocket.ThrottleDown(10)
+	rocket.ThrottleUp(1000)
+	rocket.ThrottleUp(100)
+	rocket.ThrottleUp(100)
+	rocket.ThrottleDown(10)
 	got, _ := rocket.ThrottleDown(10)
 	want := 1180
 
@@ -108,31 +113,33 @@ func TestThrottleDown(t *testing.T) {
 	}
 }
 
+//nolint:errcheck
 func TestThrottleDownToUnder1000(t *testing.T) {
 	rocket := NewRocket("Saturn-V", "Nasa", 5, 25000)
 	rocket.AddFuel(100)
 
-	_ = rocket.Ignite()
+	rocket.Ignite()
 
-	_, _ = rocket.ThrottleUp(900)
+	rocket.ThrottleUp(900)
 	_, err := rocket.ThrottleDown(10)
 
 	if err == nil {
 		t.Errorf("Expected error when attempting to throttle down with resulting speed less than 1000")
 	}
 }
 
+//nolint:errcheck
 func TestCurrentSpeed(t *testing.T) {
 	rocket := NewRocket("Saturn-V", "Nasa", 5, 25000)
 	rocket.AddFuel(100)
 
-	_ = rocket.Ignite()
+	rocket.Ignite()
 
-	_, _ = rocket.ThrottleUp(1000)
-	_, _ = rocket.ThrottleUp(100)
-	_, _ = rocket.ThrottleDown(10)
-	_, _ = rocket.ThrottleUp(100)
-	_, _ = rocket.ThrottleDown(5)
+	rocket.ThrottleUp(1000)
+	rocket.ThrottleUp(100)
+	rocket.ThrottleDown(10)
+	rocket.ThrottleUp(100)
+	rocket.ThrottleDown(5)
 
 	got := rocket.CurrentSpeed()
 	want := 1185

pkg/rocket/rocket_test2.go renamed to pkg/rocket/rocket_test_spec.go

@@ -44,32 +44,36 @@ var _ = Describe("Rocket", func() {
 				Expect(err).ShouldNot(HaveOccurred())
 			})
 
+			//nolint:errcheck
 			It("can throttle down successfully as long as it's resulting speed does not drop below 1000", func() {
-				_, _ = rocket.ThrottleUp(2000)
+				rocket.ThrottleUp(2000)
 				speed, err := rocket.ThrottleDown(100)
 				Expect(speed).Should(Equal(1900))
 				Expect(err).ShouldNot(HaveOccurred())
 			})
 
+			//nolint:errcheck
 			It("will throw an error if it trys to throttle up and it's resulting speed exceeds its max speed", func() {
-				_, _ = rocket.ThrottleUp(25000)
+				rocket.ThrottleUp(25000)
 				_, err := rocket.ThrottleUp(1)
 
 				Expect(err).Should(HaveOccurred())
 			})
 
+			//nolint:errcheck
 			It("will throw an error if it trys to throttle down and it's resulting speed is less than 1000", func() {
-				_, _ = rocket.ThrottleUp(2000)
+				rocket.ThrottleUp(2000)
 				_, err := rocket.ThrottleDown(1500)
 
 				Expect(err).Should(HaveOccurred())
 			})
 
+			//nolint:errcheck
 			It("tracks it's current speed", func() {
-				_, _ = rocket.ThrottleUp(2000)
-				_, _ = rocket.ThrottleDown(5)
-				_, _ = rocket.ThrottleDown(10)
-				_, _ = rocket.ThrottleUp(200)
+				rocket.ThrottleUp(2000)
+				rocket.ThrottleDown(5)
+				rocket.ThrottleDown(10)
+				rocket.ThrottleUp(200)
 
 				Expect(rocket.CurrentSpeed()).Should(Equal(2185))
 			})