feat: implement NPV function#95
Merged
Merged
Conversation
chrispcampbell
approved these changes
Jul 27, 2021
Contributor
chrispcampbell
left a comment
chrispcampbell
left a comment
There was a problem hiding this comment.
Looks good to me. I verified that the new npv test passes as expected. I'll merge this to develop shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
This was a straightforward adaptation of the code for the TREND function with the added wrinkle of needing to generate two level vars instead of just one. This shows up when we add reference, but is otherwise unremarkable. The code for the NPV function is taken from the Vensim docs. I committed a test model that validates the expansion in the docs, but removed that in the final version, since we don't need it to validate SDEverywhere code generation.