feat: implement GET DIRECT CONSTANTS for CSV#86
Merged
Conversation
chrispcampbell
changed the title
chrispcampbell
approved these changes
Jul 26, 2021
Contributor
chrispcampbell
left a comment
chrispcampbell
left a comment
There was a problem hiding this comment.
Looks good to me. I merged the latest from develop into this branch, changed the path passed to readCsv to be relative to the model directory (like we did for previous branches), and then verified that all tests are passing, so I think this is ready to be merged. I'll merge it shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
GET DIRECT CONSTANTS is implemented during code generation by reading the CSV file and generating a constant initialization for each cell value. A test model is included that covers zero, one, and two dimensions of data (all the possibilities for a CSV file in Vensim). One test covers the case where subscripts occur in a different order on the LHS than in the data.