feat: include grouped and sorted arrays of variable instances in JSON listing#681
Merged
Merged
Conversation
ToddFincannonEI
approved these changes
Oct 17, 2025
Collaborator
ToddFincannonEI
left a comment
ToddFincannonEI
left a comment
There was a problem hiding this comment.
The code looks fine to me. I can't run it right now, because I'm in the middle of debugging a cyclic dependency in the latest EPS model, and I don't want to disturb my local working copy. This looks like it will be very helpful for debugging once I can merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #534
@ToddFincannonEI: I'm requesting your review on this one since it's in the core of the compiler and I wanted to bring it to your attention. It doesn't have any impact on the behavior of the compiler and doesn't affect the existing JSON listing format (it only adds a new object to that listing file).
For reference, I already merged a couple small refactoring PRs that made these changes easier, see #678 and #680. They were low-risk and well covered by tests so I figured I'd merge those first and send this one for your review to make it easier to see the distinct sets of changes.