feat: add support for external data variables with > 2 dimensions#47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary change here was to generalize the code that handles subscripted external data variables so that it works for any number of dimensions. That also helped make the code more succinct.
I extended the
extdatatest case to include a 3-dimensional data variable and added aVECTOR SELECTscenario that mimics something in the En-ROADS model. That uncovered a bug where SDE was not emitting aLOOKUPcall when the external data variable is referenced inside aVECTOR SELECT. I fixed that invisitVarso that we use some existing code that emits aLOOKUPwhen a data variable is used insideVECTOR SELECT.Fixes #45