fix: correct generation of level variables when SMOOTH3[I] input param has subscripts but delay param does not#457
Merged
Conversation
Collaborator
ToddFincannonEI
left a comment
ToddFincannonEI
left a comment
There was a problem hiding this comment.
This fix looks like a straightforward solution that should not cause any problems for EPS.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313
This fixes an issue that we ran into with En-ROADS, but was also reported last week in #449 (will be closed as a duplicate). See #313 for more details on the cause and the fix.
To help verify this fix, I've added new tests for the equation reading phase (when the level vars are synthesized for the implementation of
SMOOTH3[I]) and for the code gen phase.I also verified that this fixes the issue reported in the duplicate issue #449.
I decided to only fix this in the "new"
readEquationscode, since the oldEquationReaderis no longer enabled by default and will be removed in the near future.